Errors and logs improvements #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logs were erased by the error raising when shutting down the server. In the end, appending to the logs and just erasing it when the server starts, is the solution employed here. server: - Deleted init_logger function as it has been moved to logger.py since a while. - Replaced the print here and there by logger.log.info - Updated the exceptions handlers in handler to display the error. - Updated shutdown_server to receive an exit code and to display a message. logger: - Added delete_log_file function. - Updated init_logger to call delete_log_file. config: - LOG_FILEMODE default value is now "a" again. The log file is now manually deleted to avoid losing logs.
- Updated _load to display messages as error instead of info when an error happens when loading the tokens. - Updated __init__ to log as error "Couldn't load the model files." instead of info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.