Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to load .ini config file in MS Store version #6

Closed
TuxoYKT opened this issue Feb 24, 2023 · 15 comments
Closed

Fails to load .ini config file in MS Store version #6

TuxoYKT opened this issue Feb 24, 2023 · 15 comments

Comments

@TuxoYKT
Copy link

TuxoYKT commented Feb 24, 2023

IshinFix expects the config file to be read from "Win64" folder, while MS Store version uses "WinGDK" folder for its binaries.
IshinFix.log

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 24, 2023

Was able to compile IshinFix with different config path to "WinGDK" and the config can be read with no issues. Tested all the available options and here are some of the results.

  • Fix Aspect Ratio (crashes after applying the LetterBox hook)
  • Fix FOV (fails at pattern scan for FOV Culling, no crash)
  • Remove Cutscene FPS Cap (works)
  • Override Controller Icons (works)

@Lyall
Copy link
Owner

Lyall commented Feb 24, 2023

Nice work, this is good to know. Can you upload the main shipping executable for the MS Store version? Or is it locked down due permission issues?

I already detect the executable name and path, I could add a check for the MS Store version based on that and change config path accordingly. With regards to the patterns failing, I'd need to see the exe to compare. It's possible that the offsets would be completely different and supporting that would mean different versions of each fix.

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 24, 2023

I can access the game files without any issues. I can send you the necessary files you need, but not sure if it's okay uploading these here. Any suggestions on how to and where to upload them with no problems?

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 24, 2023

I've dumped the main shipping executable using UWPDumper. Can't seem to find any good places to upload it and send it to you.

@Lyall
Copy link
Owner

Lyall commented Feb 24, 2023

PixelDrain is a good quick and easy place to upload stuff. I doubt there's much risk in uploading given the exe contains Denuvo. No one could really do anything with it beyond looking at it forensically. Could always just delete the link after I confirm I got it.

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 24, 2023

PixelDrain upload speeds were too low, and it would take hours to upload. I was able to upload it into Discord with no issues.

@Lyall
Copy link
Owner

Lyall commented Feb 24, 2023

Okay, going to take a look at it and compare just now. I'll update this post further.

  • Letterbox fix: The registers are different, would need to have an alternate fix for that one or rework the current solution.
  • Current resolution: One value is different, could possibly change this to accommodate as the hook location was not too important.
  • Aspect/FOV: Looks the same, all good.
  • Minigame aspect ratio: Looks the same.
  • FOV Culling: Can't find that easily in the MS Store version, needs more research.
  • Cutscene FPS: Looks the same.
  • Controller Type Override: Exact same.

So all in all, only a few differences. I can probably work around them and come up with solutions for the letterbox part and current resolution check. As for the FOV culling, I'll need to look at that further.

@Lyall
Copy link
Owner

Lyall commented Feb 25, 2023

Okay after a fair bit of work I have hopefully adapted it so that it can be used on the Microsoft Store version. Give this release a try and let me know how it goes. A log file would be much appreciated.

IshinFix_v1_0_4_test.zip

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 25, 2023

Still crashes if you apply Aspect Ratio fix.
IshinFix.log

@Lyall
Copy link
Owner

Lyall commented Feb 25, 2023

Looks like the register that has the address for the border objects was incorrect, it's r15 in the MS Store version. Give this a try.

IshinFix_v1_0_4_test2.zip

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 25, 2023

image

Now it doesn't crash and seems to be working fine.

@Lyall
Copy link
Owner

Lyall commented Feb 25, 2023

Excellent. I know it's a bit of a favour to ask but can you try enabling all the features in the ini and just checking that they work? I'm fairly sure they should but without having the game, I cannot verify myself.

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 25, 2023

All the options works fine including the Fix FOV. However, I can't seem to make AdditionalFOV option to work. I tried changing values and saw no changes.

@Lyall
Copy link
Owner

Lyall commented Feb 25, 2023

Looks like I forgot to add back in the additional FOV functionality when I switched the FOV method. I have added that functionality back.

Thanks for verifying that it all works on the MS Store version now. I think it's probably good enough now to push in the next release.

@TuxoYKT
Copy link
Author

TuxoYKT commented Feb 25, 2023

I want to say thanks for allowing the people who bought the MS Store version to have those fixes.

@TuxoYKT TuxoYKT closed this as completed Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants