Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGS 2: Codec Static and other scaling issues #8

Closed
kite1234567 opened this issue Oct 28, 2023 · 20 comments
Closed

MGS 2: Codec Static and other scaling issues #8

kite1234567 opened this issue Oct 28, 2023 · 20 comments
Labels
MGS2 Metal Gear Solid 2

Comments

@kite1234567
Copy link

everything looks great now . the only thing noticed so far is the codec calls static overlay for their faces.

@TerrorThrills
Copy link

Just to add an image. It appears the photo flash layer and static are both being rendered at a lower resolution the previous versions

20231028020325_1

@kite1234567
Copy link
Author

kite1234567 commented Oct 28, 2023

https://i.gyazo.com/6a994fba081561afb22478ecaabca8cd.mp4 heres another strange one.
its not too bad but the scent of the c4 on the radar is offset

@Lyall Lyall changed the title Codec Static MGS 2: Codec Static and other scaling issues Oct 28, 2023
@Lyall Lyall mentioned this issue Oct 28, 2023
@kite1234567
Copy link
Author

kite1234567 commented Oct 28, 2023

seems to be the same with water as well as bomb scent

https://i.gyazo.com/43bd64a61b3f9f22df8c126df3ccc50b.mp4
not very good footage but you get the idea

@Blackbird88
Copy link

Codec was fixed in MGSResolutionPatch so it's possible
Sergeanur/MGSResolutionPatch@b9adc9a

Lyall added a commit that referenced this issue Oct 29, 2023
MGS 3: Renamed mouse sens multiplier variable.
@Lyall
Copy link
Owner

Lyall commented Oct 29, 2023

This latest release (v0.7) should help with the codec issues. I don't know if the later issues shown here like the minimap bomb scent/water are fixed so it would be good to get some feedback.

@TerrorThrills
Copy link

TerrorThrills commented Oct 29, 2023

I htink those effects are natural to the game as the bomb location and water indicators are located at a higher y axis than the map. You would probably need to someone to test on the HD collection in order to verify that.

@kite1234567
Copy link
Author

I htink those effects are natural to the game as the bomb location and water indicators are located at a higher y axis than the map. You would probably need to someone to test on the HD collection in order to verify that.

It’s never been that way across any version the axis y axis doesn’t matter since the map is orthographic

@Lyall
Copy link
Owner

Lyall commented Oct 29, 2023

On that note, if the other issues like the bomb scent etc are still there, uploading a save game with it would be very handy for testing.

@Lyall Lyall added the MGS2 Metal Gear Solid 2 label Oct 29, 2023
@kite1234567
Copy link
Author

On that note, if the other issues like the bomb scent etc are still there, uploading a save game with it would be very handy for testing.

im not home or i would do it, have you considered the dev mod to just warp to that location? https://www.nexusmods.com/metalgearsolidmastercollection/mods/1

@Lyall
Copy link
Owner

Lyall commented Oct 30, 2023

On that note, if the other issues like the bomb scent etc are still there, uploading a save game with it would be very handy for testing.

im not home or i would do it, have you considered the dev mod to just warp to that location? https://www.nexusmods.com/metalgearsolidmastercollection/mods/1

That's a good shout. I tried that and loaded up the water part and it seems to render okay now.

Vanilla
https://github.com/Lyall/MGSHDFix/assets/695941/f396d558-e0b0-4e9b-b887-b9270d4ecb0f

MGSHDFix v0.7
https://github.com/Lyall/MGSHDFix/assets/695941/2f89286d-75b8-4ce0-a5ca-31c0adc72e45

Edit: Bomb scent

Vanilla
https://github.com/Lyall/MGSHDFix/assets/695941/85fbf8e8-30e0-4489-9ad6-b066abd40d2d

MGSHDFix v0.7
https://github.com/Lyall/MGSHDFix/assets/695941/3da4e918-e4f9-4f19-8914-67ef8a800ad4

@kite1234567
Copy link
Author

On that note, if the other issues like the bomb scent etc are still there, uploading a save game with it would be very handy for testing.

im not home or i would do it, have you considered the dev mod to just warp to that location? https://www.nexusmods.com/metalgearsolidmastercollection/mods/1

That's a good shout. I tried that and loaded up the water part and it seems to render okay now.

Vanilla https://github.com/Lyall/MGSHDFix/assets/695941/f396d558-e0b0-4e9b-b887-b9270d4ecb0f

MGSHDFix v0.7 https://github.com/Lyall/MGSHDFix/assets/695941/2f89286d-75b8-4ce0-a5ca-31c0adc72e45

Edit: Bomb scent

Vanilla https://github.com/Lyall/MGSHDFix/assets/695941/85fbf8e8-30e0-4489-9ad6-b066abd40d2d

MGSHDFix v0.7 https://github.com/Lyall/MGSHDFix/assets/695941/3da4e918-e4f9-4f19-8914-67ef8a800ad4

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

@ConnorBarr
Copy link

ConnorBarr commented Oct 31, 2023

On that note, if the other issues like the bomb scent etc are still there, uploading a save game with it would be very handy for testing.

im not home or i would do it, have you considered the dev mod to just warp to that location? https://www.nexusmods.com/metalgearsolidmastercollection/mods/1

That's a good shout. I tried that and loaded up the water part and it seems to render okay now.
Vanilla https://github.com/Lyall/MGSHDFix/assets/695941/f396d558-e0b0-4e9b-b887-b9270d4ecb0f
MGSHDFix v0.7 https://github.com/Lyall/MGSHDFix/assets/695941/2f89286d-75b8-4ce0-a5ca-31c0adc72e45
Edit: Bomb scent
Vanilla https://github.com/Lyall/MGSHDFix/assets/695941/85fbf8e8-30e0-4489-9ad6-b066abd40d2d
MGSHDFix v0.7 https://github.com/Lyall/MGSHDFix/assets/695941/3da4e918-e4f9-4f19-8914-67ef8a800ad4

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

I've just ran both sets of videos in Nvidia ICAT, the videos don't follow the exact same path so i can't guarantee 100% but it looks correct to me.

@Lyall
Copy link
Owner

Lyall commented Nov 1, 2023

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

Check out this footage of the PS3 version being played, I've timestamped the same bomb scent area. It looks to match up to my eyes.

You're right though that it does look "off" but as you can see that's how it looks in the HD collection. Maybe it looked different in the PS2 original?

@ConnorBarr
Copy link

ConnorBarr commented Nov 1, 2023

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

Check out this footage of the PS3 version being played, I've timestamped the same bomb scent area. It looks to match up to my eyes.

You're right though that it does look "off" but as you can see that's how it looks in the HD collection. Maybe it looked different in the PS2 original?

I think your right this might have been a difference between the HD collection and the PS2. Here is a video of the game in PCSX2, It seems to be completly static unlike the PS3 Collection.

Here is a link to the PCSX2 Footage (20:46): https://www.youtube.com/watch?v=-lEYdMRIqBA
I also found this footage which follows the same behaviour as above but i cant find what platfrom its on but i think it is native PS2 (3:47): https://www.youtube.com/watch?v=xdF-LGiTsB0

@Lyall
Copy link
Owner

Lyall commented Nov 1, 2023

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

Check out this footage of the PS3 version being played, I've timestamped the same bomb scent area. It looks to match up to my eyes.
You're right though that it does look "off" but as you can see that's how it looks in the HD collection. Maybe it looked different in the PS2 original?

I think your right this might have been a difference between the HD collection and the PS2. Here is a video of the game in PCSX2, It seems to be completly static unlike the PS3 Collection.

Here is a link to the PCSX2 Footage (20:46): https://www.youtube.com/watch?v=-lEYdMRIqBA I also found this footage which follows the same behaviour as above but i cant find what platfrom its on but i think it is native PS2 (3:47): https://www.youtube.com/watch?v=xdF-LGiTsB0

It almost looks like the scent marker is contained to a bounding box. That bounding box presumably not being scaled incorrectly with the HD conversion to 16:9.

@ConnorBarr
Copy link

huh it looks good on a horizontal axis but i think its still pretty wonky vertically. either way this is more than exceptional thanks for all this work.

Check out this footage of the PS3 version being played, I've timestamped the same bomb scent area. It looks to match up to my eyes.
You're right though that it does look "off" but as you can see that's how it looks in the HD collection. Maybe it looked different in the PS2 original?

I think your right this might have been a difference between the HD collection and the PS2. Here is a video of the game in PCSX2, It seems to be completly static unlike the PS3 Collection.
Here is a link to the PCSX2 Footage (20:46): https://www.youtube.com/watch?v=-lEYdMRIqBA I also found this footage which follows the same behaviour as above but i cant find what platfrom its on but i think it is native PS2 (3:47): https://www.youtube.com/watch?v=xdF-LGiTsB0

It almost looks like the scent marker is contained to a bounding box. That bounding box presumably not being scaled incorrectly with the HD conversion to 16:9.

That does sound possible but is there a way to verify? Would setting the aspect ratio to the orignal 4:3 make a difference or would the scale be off regardless?

@kite1234567
Copy link
Author

classic HD collection bugs at it again...

@Lyall
Copy link
Owner

Lyall commented Nov 1, 2023

So with this being a confirmed HD collection bug is there any interest in fixing it? I'd consider the issue to be pretty minor so I probably won't do much research into unless others deem it important enough.

@ConnorBarr
Copy link

ConnorBarr commented Nov 1, 2023

So with this being a confirmed HD collection bug is there any interest in fixing it? I'd consider the issue to be pretty minor so I probably won't do much research into unless others deem it important enough.

I think it’s fine as it is, it’s been this way for 10+ years with the HD collection and I haven’t seen any one mention it so it isn't causing any adverse effect.

It’s also technically not related to this issue as it isn’t caused by modifying the resolution, as this is the ‘intended’ behaviour even at native.

@Lyall
Copy link
Owner

Lyall commented Nov 1, 2023

So with this being a confirmed HD collection bug is there any interest in fixing it? I'd consider the issue to be pretty minor so I probably won't do much research into unless others deem it important enough.

I think it’s fine as it is, it’s been this way for 10+ years with the HD collection and I haven’t seen any one mention it so it isn't causing any adverse effect.

It’s also technically not related to this issue as it isn’t caused by modifying the resolution, as this is the ‘intended’ behaviour even at native.

All right, will leave it as is. As for this issue overall I think it's pretty much sorted now. As always if anyone runs in to any issues related to it, feel free to open a new issue.

@Lyall Lyall closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MGS2 Metal Gear Solid 2
Projects
None yet
Development

No branches or pull requests

5 participants