Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted with suggested CSS #2413

Merged
merged 7 commits into from
Apr 28, 2024
Merged

Adjusted with suggested CSS #2413

merged 7 commits into from
Apr 28, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 26, 2024

No description provided.

@Colossus68
Copy link

Swipe works.

Scroll does not work for me as expected. Shouldn't the parent element #lychee_sidebar_container contain the overflow-y scroll, not #lychee_sidebar?

That's what worked:
#lychee_sidebar_container {
overflow-x: clip;
overflow-y: auto;
}
#lychee_sidebar {
padding-right: 15px;
overflow-wrap: anywhere;
}

@ildyria
Copy link
Member Author

ildyria commented Apr 26, 2024

@Colossus68 adjusted. Please check :)

@Colossus68
Copy link

Colossus68 commented Apr 26, 2024

overflow-y-scroll{overflow-y:scoll} missing in public/build/assets/app-B0Q6gW3r.css ?
Whit this it works.

@ildyria
Copy link
Member Author

ildyria commented Apr 26, 2024

overflow-y-hidden{overflow-y:hidden} missing in public/build/assets/app-B0Q6gW3r.css ?

You probably need to rebuild the front-end with npm run build so that the class is added by tailwind.

@Colossus68
Copy link

sorry, my fault. Never worked with this bevor. Not a programmer

@ildyria
Copy link
Member Author

ildyria commented Apr 26, 2024

No worries. :)
You added the correct class, making it work :)

@ildyria ildyria requested a review from d7415 April 28, 2024 11:46
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Apr 28, 2024
@ildyria ildyria merged commit ffcb72d into master Apr 28, 2024
31 checks passed
@ildyria ildyria deleted the fix-ui branch April 28, 2024 14:59
@ildyria ildyria mentioned this pull request May 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants