Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to Logs in case of sub folder hosting #2624

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix link to Logs in case of sub folder hosting #2624

merged 1 commit into from
Oct 29, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 29, 2024

No description provided.

@ildyria ildyria added this to the 6.0.1 milestone Oct 29, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 29, 2024
d7415
d7415 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants.BASE_URL includes the leading /, right?

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (913511a) to head (a078ecb).
Report is 4 commits behind head on master.

Additional details and impacted files

@d7415
Copy link
Contributor

d7415 commented Oct 29, 2024

Constants.BASE_URL includes the leading /, right?

Based on other code I'm going to assume yes

@ildyria
Copy link
Member Author

ildyria commented Oct 29, 2024

Constants.BASE_URL includes the leading /, right?

even better, it is fetched directly from here:

Lychee/resources/views/components/meta.blade.php

Line 1 in 913511a

<base href="{{ $baseUrl }}" />

And defined here:

Lychee/app/View/Components/Meta.php

Line 68 in 913511a

$this->baseUrl = url('/');

@ildyria ildyria merged commit 4f13ee7 into master Oct 29, 2024
49 checks passed
@ildyria ildyria deleted the fix-link-logs branch October 29, 2024 21:52
aSouchereau pushed a commit that referenced this pull request Nov 9, 2024
@ildyria @aSouchereau
Fix link to Logs in case of sub folder hosting (#2624)
1aed4d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415