Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare ground work for timeline #2631

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Prepare ground work for timeline #2631

merged 2 commits into from
Oct 30, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 30, 2024

Some refactoring to avoid later code duplication.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (6fc3e35) to head (55bcd66).
Report is 3 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 0f9225c into master Oct 30, 2024
49 checks passed
@ildyria ildyria deleted the refactoring-init-settings branch October 30, 2024 22:14
aSouchereau pushed a commit that referenced this pull request Nov 9, 2024
@ildyria @aSouchereau
Prepare ground work for timeline (#2631)
65f6c62 
* Prepare ground work for timeline

* add condition back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415