Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring #2689

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Minor refactoring #2689

merged 1 commit into from
Nov 15, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 14, 2024

Just type stuff.

@ildyria ildyria requested a review from d7415 November 14, 2024 17:37
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Nov 14, 2024
@ildyria ildyria added this to the 6.1.0 milestone Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (fe68b5f) to head (e848ce4).
Report is 3 commits behind head on master.

Additional details and impacted files

d7415
d7415 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

function isNotEmpty(link: string | null | undefined): link is string {

confuses the hell out of me, but I'm going to assume it makes sense.

@ildyria ildyria merged commit 14514f4 into master Nov 15, 2024
49 checks passed
@ildyria ildyria deleted the mini-refactor branch November 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415