Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the plaintext-field to a password-field in AlbumUnlock #2757

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Gendra13
Copy link
Contributor

During my investigations regarding #2696 I noticed that the input field in the album unlock window is a plaintext field and not a password field, so the entered text is not hidden (●●●).

field

This PR changes this behavoir and replaces the text-field with a password-field.

change InputText to InputPassword
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (9743704) to head (1fb4915).
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 6060e94 into LycheeOrg:master Nov 27, 2024
32 checks passed
@Gendra13 Gendra13 deleted the pw-field-hide-chars branch November 27, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants