Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 413 #414

Merged
merged 4 commits into from
Dec 26, 2019
Merged

Fix issue 413 #414

merged 4 commits into from
Dec 26, 2019

Conversation

tmp-hallenser
Copy link
Contributor

Fix for issue #413

@codecov-io
Copy link

codecov-io commented Dec 25, 2019 •
edited
Loading

Codecov Report

Merging #414 into master will increase coverage by 0.6%.
The diff coverage is 71.42%.

ildyria
ildyria approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

Feel free to ignore my comment. :)

app/Metadata/Extractor.php Show resolved Hide resolved
@tmp-hallenser tmp-hallenser merged commit 073b2a4 into master Dec 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-413 branch December 26, 2019 19:08
@ildyria ildyria mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmp-hallenser @codecov-io @ildyria