Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor WiFi BSSID string sanitation causes malformed CSV file #1

Open
AlexLynd opened this issue Jul 21, 2023 · 4 comments
Open

Poor WiFi BSSID string sanitation causes malformed CSV file #1

AlexLynd opened this issue Jul 21, 2023 · 4 comments
Assignees
@AlexLynd
Labels
bug Something isn't working

Comments

@AlexLynd
Copy link
Contributor

Values are popping up in the wrong places and I suspect this is due to poor sanitation of WiFi names (BSSID's) which might contain commas.
@AlexLynd AlexLynd self-assigned this Jul 21, 2023
@lukeswitz
Copy link
Contributor

lukeswitz commented Jul 21, 2023 •
edited
Loading

Tricky one- could be SSID with quotes in it, or commas,

It skips the firstSeen column after the name and fills in all data, stretching the csv doc to contain an extra column on the end:

(MAC & Location data redacted)

SSID FirstSeen AuthMode Channel Signal Strength Latitude Longitude Altitude Accuracy Type
ARLO_VMB_1576818505 2023-7-20 18:12:10 [WPA2-PSK-CCMP+TKIP][ESS] 3 -90 xxxxxxxxxx xxxxxxxxxxx xxxxxxxx 0.820000 WIFI
Jerrynet5.0 2023-7-20 18:12:10 [WPA2-PSK-CCMP+TKIP][ESS] 11 -70 xxxxxxxxxx xxxxxxxxxxx xxxxxxxx 0.820000 WIFI
Kitchen speaker.o 2023-7-20 18:12:10 [ESS] 6 -86 xxxxxxxxxx xxxxxxxxxxx xxxxxxxx 0.820000 WIFI
Bose Wave ST (DC6885) 2023-7-20 18:11:39 [ESS] 1 xxxxxxxx xxxxxxxx xxxxxx 0.820000 WIFI

Confirmed by a second capture of the Kitchen speaker.o network and other networks containing similar syntax

@AlexLynd AlexLynd added the bug Something isn't working label Aug 5, 2023
@lukeswitz
Copy link
Contributor

lukeswitz commented Aug 6, 2023 •
edited
Loading

Another problem with the CSV was using int for the day-month min:sec. Using %02d in strDateTime fixes this when it’s written later.

@AlexLynd
Copy link
Contributor Author

AlexLynd commented Aug 6, 2023

@lukeswitz heck i still have to fix the original issue, and also the wigle upload - this should be solved in the latest revision though!

lukeswitz referenced this issue in lukeswitz/Wardriver Aug 8, 2023
@lukeswitz
#1 Sanitize SSID for CSV output
cf8e53c 
Wrapped SSID in double quotes to handle potential special characters.
- Escaped internal double quotes in SSID for CSV compliance.
- Ensured CSV formatting remains consistent even if SSID contains
disruptive characters.
lukeswitz referenced this issue in lukeswitz/Wardriver Aug 8, 2023
@lukeswitz
Address #1 Sanitize SSID for CSV
e8d0b49 
Wrapped SSID in double quotes to handle potential special characters.
- Escaped internal double quotes in SSID for CSV compliance.
- Ensured CSV formatting remains consistent even if SSID contains disruptive characters.
AlexLynd added a commit that referenced this issue Aug 17, 2023
@AlexLynd
Merge pull request #8 from lukeswitz/Fix-ssid-csv
2c42214 
#1 Sanitize SSID for CSV output
@lukeswitz
Copy link
Contributor

Still happens with some networks. No idea. Same as above.

@lukeswitz lukeswitz mentioned this issue Oct 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexLynd AlexLynd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukeswitz @AlexLynd