Cleaning up GTK2 relicts (following PR #287) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I have been trying to build this nice app to run it on the PinePhone (see my PKGBUILD script for more) and realized that there were some GTK2-GUI remains in the Makefile and the packaging folder, which this PR cleans up.
This PR also touches the README and adds the PinePhone as a supported device (it works: video, the only issue is the window size after starting the app (defaulting to 640*520 px?).
Important: The README needs more editing before merging this - I think it would be beneficial to refer users of legacy devices to the last release that works for their devices.
Thanks for creating this app!
BTW: It would be nice to tag a release soon-ish to enable distributions to package this software! 🙂