Update react-map-gl package to fix Geolocation toggle bug #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
react-map-glto allow user to toggle geolocation on and offSide note: this fix only works in Chrome. It isn't entirely clear whether or not even the non-React-wrapper version of Geolocate works in Firefox or Safari (see this PR regarding the move to mapbox-gl-js 1.5.0), but in any case, investigating further will require updating the mapbox-gl package. I tried seeing if I could quickly do that but there's some versioning shenanigans that will take a little while to sort through. I will open an issue and link back here afterwards.
Update: opened issue #53