Code

GH 731 review#341

Code

Closed

czarte wants to merge 24 commits intomasterMASQ-Project/Node:masterfrom GH-731MASQ-Project/Node:GH-731Copy head branch name to clipboard

+901-151

Commits

Commits on Aug 23, 2023

• begining with test server_initializer_collected_params_combine_vlcs_properly

  czarte

  committed
  cedb1b3

Commits on Aug 28, 2023

• removed GatheredParams from server_initializer_collected_params, added bools for data_dir, config_file and real_user to MultiConfig, fixing the test

  czarte

  committed
  32dd2cb

Commits on Aug 29, 2023

• add ComputedVcl struct and its implementation, add VclType enum, to be able to push into Vcl Vector, add processing in MultiConfig, add processing in server_initializer_collected_params

  czarte

  committed
  690b099

Commits on Aug 30, 2023

• back to VirtualCommandLine type without enum, passing different types to MultiConfig and selecting them to computed_value_names on behalf of their type

  czarte

  committed
  0d7427b

Commits on Aug 31, 2023

• fixed data flow with Evironment and Command line arguments, need to fix config file arguments data

  czarte

  committed
  22e607b

Commits on Sep 4, 2023

• changes in test to access config.file for various scenarios, add machinery to determine if real-user is specified in config-file

  czarte

  committed
  b9a6e85

Commits on Sep 13, 2023

• try to get rid of redundant MultiConfig construction in determine_user_specific_data

  czarte

  committed
  08349e2

Commits on Sep 15, 2023

• handle computed arguments in multiconfig, closure for server_initializer_collected_params, closure for keeping in node_configurator, final removal of redundant construction of multiconfig

  czarte

  committed
  8aead2a

Commits on Sep 21, 2023

• computing env_args and cmd_args in create_preorientation_args fn!

  czarte

  committed
  6167856

Commits on Oct 4, 2023

• fix passing test server_initializer_collected_params_can_read_parameters_from_config_file, some optimization

  czarte

  committed
  7286ee8

Commits on Oct 11, 2023

• fixed VclArg problem with withdrawing data from VirtualCommandline, sorted server_initializer_collected_params and determine_user_specific_data fncs, new fns value_opt for VclArg and tests for them

  czarte

  committed
  fce6fe1

Commits on Oct 23, 2023

• finalize preparing guts for multiconfig in server_initializer_collected_params, added handling for tilde in data_directory and config_file paths

  czarte

  committed
  4dd0932

• fix windows test of real_user soecified

  czarte

  committed
  413ffc5

Commits on Oct 25, 2023

• renaming, adding TODOs, removing resolved TODOS

  czarte

  committed
  18d0cc1

Commits on Oct 30, 2023

• fixing tests for windows os

  czarte

  committed
  efd3fbb

Commits on Oct 31, 2023

• fixed on windows

  czarte

  committed
  cf6da59

Commits on Nov 1, 2023

• formatting

  czarte

  committed
  34b8fea

• removed filling specified and unspecified boxes from server_initializer_collected_params, fixed formatting for get_real_user_from_vcl

  czarte

  committed
  62e99e3

Commits on Nov 2, 2023

• fixed real user for windows

  czarte

  committed
  5895879

Commits on Nov 6, 2023

• last fixes of extract_values_and_fill_boxes, and test server_initializer_collected_params_handle_config_file_from_commandline_and_real_user_from_config_file_with_data_dir_started_by_tilde

  czarte

  committed
  8369ff9

Commits on Nov 8, 2023

• fixed windows test for tilde

  czarte

  committed
  5b02822

• fix tilde test for windows

  czarte

  committed
  0603f70

• renaming of tests and functions

  czarte

  committed
  2ec7e12

Commits on Nov 10, 2023

• remove GatheredParams (the goal), optimizing is_user_specified in MultiConfig, dealing with comments

  czarte

  committed
  fe491ab