Gh 731 review3 #372
Closed
Gh 731 review3 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarshg6
approved these changes
Jan 8, 2024
| @@ -224,25 +213,28 @@ pub fn server_initializer_collected_params<'a>( | |||
|
|
|||
| let environment_vcl = EnvironmentVcl::new(&app); | |||
| let commandline_vcl = CommandLineVcl::new(args.to_vec()); | |||
| let (unspecified_vec, specified_vec) = extract_values_vcl_fill_multiconfig_vec( | |||
| let multiconfig_for_values_extraction = make_new_multi_config( | |||
There was a problem hiding this comment.
Maybe removing the make from the function name is a good idea. You might notice this word being extensively used in the functions of test utilities. So, maybe create_new_multi_config is a better name here.
There was a problem hiding this comment.
This function is widely used in production code. I'm going to make a card out of it.
…dles_only_path_in_config_file_param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.