Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-800: Testing Issue Fix #550

Open
wants to merge 8 commits into
base: GH-800-base
Choose a base branch
from
Open

GH-800: Testing Issue Fix #550

wants to merge 8 commits into from

Conversation

utkarshg6
Copy link
Collaborator

No description provided.

utkarshg6 and others added 4 commits October 17, 2024 13:31
* GH-606: Initialize start_block to none to use latest block

* GH-606: Apply PR feedback changes

* GH-606: Apply PR feedback changes

* GH-606: Apply PR feedback changes

* GH-606: Apply PR review 4 feedback changes

* GH-606: Squashing commits

- Save start_block_nbr if no msg but send as non-Option
- Always commit
- Reduce logging levels and simplify
- Follow the Option naming pattern

* GH-600: set_start_block only called in accountant/scanners/mod.rs

* GH-606: PR Feedback - parameterize a test

* GH-606: Address PR feedback

* GH-606: Implement parameterized test without crate macro
Copy link
Collaborator

@dnwiebe dnwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to examine code for stream_handler_pool.rs and find out what line 392 should be.

node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/stream_handler_pool.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants