fix mcc not showing the disconnect message

The fix is to remove the ParseText call from the OnConnectionLost call, as the ReadNextChat function already calls ParseText. Calling ParseText on an unparsable string returns an empty string, therefore the disconnect message never gets propagated to the user.
MCCTeam · Mar 16, 2024 · dc71332 · dc71332
1 parent 706a41e
commit dc71332
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/MinecraftClient/McClient.cs b/MinecraftClient/McClient.cs
@@ -593,7 +593,7 @@ public void OnConnectionLost(ChatBot.DisconnectReason reason, string message)
                 ConsoleInteractive.ConsoleReader.StopReadThread();
                 ConsoleInteractive.ConsoleReader.MessageReceived -= ConsoleReaderOnMessageReceived;
                 ConsoleInteractive.ConsoleReader.OnInputChange -= ConsoleIO.AutocompleteHandler;
-                Program.HandleFailure(message, false, reason);
+                Program.HandleFailure(null, false, reason);
             }
         }
 

diff --git a/MinecraftClient/Protocol/Handlers/Protocol18.cs b/MinecraftClient/Protocol/Handlers/Protocol18.cs
@@ -2044,8 +2044,8 @@ private bool HandlePlayPackets(int packetId, Queue<byte> packetData)
                     handler.OnPluginChannelMessage(channel, packetData.ToArray());
                     return pForge.HandlePluginMessage(channel, packetData, ref currentDimension);
                 case PacketTypesIn.Disconnect:
-                    handler.OnConnectionLost(ChatBot.DisconnectReason.InGameKick,
-                        ChatParser.ParseText(dataTypes.ReadNextChat(packetData)));
+                    handler.OnConnectionLost(ChatBot.DisconnectReason.InGameKick, 
+                        dataTypes.ReadNextChat(packetData));
                     return false;
                 case PacketTypesIn.SetCompression:
                     if (protocolVersion is >= MC_1_8_Version and < MC_1_9_Version)