Add Sentry Error Tracking #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add Minecraft Version to error context
|
Haven't looked in to the code, so you might have already added this. |
|
We could put the DSN into repository secret/variable and populate the DSN during build-time, just like how we populate the build info. Correspondingly, the code would need to check the DSN string before initializing Sentry SDK. |
- Send the user-friendly Minecraft Version in the error logs - Capture exceptions in more parts of the application We now capture exceptions from the following locations: - Protocol18 (1.8+) Packet errors - Errors during client initialization phase (When client is about to start, session keys are NEVER sent to sentry)
The Sentry DSN will automatically be filled out on the main repository through the Github Actions build.
Update sed command
nitpick, just to make it a little bit more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sends information about the current .NET Runtime and the Operating System.
Here is a screenshot of all the information that is sent to Sentry whenever a crash occurs:
Very long screenshot
Currently uses my personal DSN.
Will need to change that to our DSN before merging.