Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prevent AntiCheat Block Breaking (In Scripts) #2697

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix prevent AntiCheat Block Breaking (In Scripts) #2697

wants to merge 3 commits into from

Conversation

Nekiplay
Copy link
Contributor

@Nekiplay Nekiplay commented Mar 5, 2024 •
edited
Loading

  • Fixed block breaking for anticheats in custom scripts
  • Added auxiliary methods for Direction

@Nekiplay Nekiplay changed the title AntiCheat fix prevent Block Breaking Fix prevent AntiCheat Block Breaking (In Scripts) Mar 5, 2024
@Nekiplay Nekiplay marked this pull request as draft March 5, 2024 16:18
@Nekiplay Nekiplay marked this pull request as ready for review March 5, 2024 16:54
@Nekiplay
Copy link
Contributor Author

Nekiplay commented Mar 5, 2024 •
edited
Loading

image

It remains to transfer part of the logic from here for auto-detection of the block breaking side, if it will be realized by someone I would not remove the manual indication of the block breaking side as well

@Nekiplay
Copy link
Contributor Author

Ready for review

@milutinke
Copy link
Member

milutinke commented Mar 30, 2024 •
edited
Loading

Looks good.
Also what is preventing you from porting that getDirection method to the MCC?
If it's the mc.player.GetEyeHeight, the eye height is 1.62 blocks high, so it can be hardcoded.
Also, where is that method from by the way?

@Nekiplay
Copy link
Contributor Author

Nekiplay commented Mar 30, 2024 •
edited
Loading

Looks good. Also what is preventing you from porting that getDirection method to the MCC? If it's the mc.player.GetEyeHeight, the eye height is 1.62 blocks high, so it can be hardcoded. Also, where is that method from by the way?

getDirection I probably won't reschedule.
getDirection method from Meteor Client
GetHorizontalFacing from Minecraft Code

@milutinke
Copy link
Member

Looks good. Also what is preventing you from porting that getDirection method to the MCC? If it's the mc.player.GetEyeHeight, the eye height is 1.62 blocks high, so it can be hardcoded. Also, where is that method from by the way?

getDirection I probably won't reschedule. getDirection method from Meteor Client GetHorizontalFacing from Minecraft Code

Does this work as is without getDirection method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nekiplay @milutinke