Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mcs-lite-connect): add isWebSocketClose feature [BREAKING] #234

Merged
merged 6 commits into from
Mar 16, 2017

Conversation

evenchange4
Copy link
Member

@evenchange4 evenchange4 commented Mar 16, 2017

[mcs-lite-connect] BREAKING:
Replace the third argument of connectSocket with propsMapper: Function.

-    'sendMessage', // propsName
+    ({ readyState, send, createWebSocket }) => ({
+      sendMessage: send,
+      isWebSocketClose: readyState.sender === 3 || readyState.viewer === 3,
+      reconnect: createWebSocket,
+    }),

for #173

@evenchange4 evenchange4 self-assigned this Mar 16, 2017
@evenchange4 evenchange4 changed the title feat(mcs-lite-connect): add isWebSocketClose feature feat(mcs-lite-connect): add isWebSocketClose feature Mar 16, 2017
@evenchange4
Copy link
Member Author

Deploy preview ready!

Built with commit 737a2fa74210ce4c0a949a5b03cda419f28319c5

https://deploy-preview-234--mcs-lite-introduction.netlify.com

@evenchange4
Copy link
Member Author

Deploy preview ready!

Built with commit 737a2fa74210ce4c0a949a5b03cda419f28319c5

https://deploy-preview-234--mcs-lite-ui.netlify.com

@evenchange4
Copy link
Member Author

Deploy preview ready!

Built with commit 737a2fa74210ce4c0a949a5b03cda419f28319c5

https://deploy-preview-234--mcs-lite-mobile-web.netlify.com

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #234 into master will decrease coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   92.64%   92.52%   -0.13%     
==========================================
  Files         129      131       +2     
  Lines        1020     1030      +10     
==========================================
+ Hits          945      953       +8     
- Misses         75       77       +2
Impacted Files Coverage Δ
...eb/src/containers/DeviceDataChannelDetail/index.js 50% <0%> (-7.15%)
...te-mobile-web/src/containers/DeviceDetail/index.js 50% <0%> (-10%)
...DeviceDataChannelDetail/DeviceDataChannelDetail.js 100% <100%> (ø)
...le-web/src/containers/DeviceDetail/DeviceDetail.js 88.88% <100%> (ø)
...b/src/components/WebSocketNotification/messages.js 100% <100%> (ø)
...nts/WebSocketNotification/WebSocketNotification.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22447fd...ec35f76. Read the comment docs.

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 16, 2017

Deploy preview ready!

Built with commit ec35f76

https://deploy-preview-234--mcs-lite-introduction.netlify.com

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 16, 2017

Deploy preview ready!

Built with commit ec35f76

https://deploy-preview-234--mcs-lite-ui.netlify.com

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 16, 2017

Deploy preview ready!

Built with commit ec35f76

https://deploy-preview-234--mcs-lite-mobile-web.netlify.com

@evenchange4 evenchange4 changed the title feat(mcs-lite-connect): add isWebSocketClose feature feat(mcs-lite-connect): add isWebSocketClose feature [BREAKING] Mar 16, 2017
@michaelhsu-bot
Copy link
Collaborator

Warnings
⚠️ ❗ Big PR

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants