Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated line length in code contrib section #348

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Dec 1, 2023

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, @orbeckst! Just one minor change.

doc/source/contributing_code.rst Outdated Show resolved Hide resolved
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
@orbeckst
Copy link
Member Author

Sorry @lilyminium this one totally slipped off my radar. Thank you for the suggested fix.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for picking this up again @orbeckst!

@lilyminium lilyminium merged commit f93cb87 into develop Jan 15, 2024
3 of 4 checks passed
@lilyminium lilyminium deleted the update-line-lengths branch January 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update line length in Contributor guide
2 participants