Revert test matrix back to manual #111
There are no files selected for viewing
|
There was a problem hiding this comment. Something I had to do with the broken kits was bump up the conda-incubator/setup-miniconda version. I found a lot of times that v2 would fail with osx-arm64 for some reason or another. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,31 +23,21 @@ defaults: | |
| shell: bash {% if cookiecutter.__dependency_source != 'pip' %} -l {0} {% endif %} | ||
|
|
||
| jobs: | ||
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| main-tests: | ||
| if: "github.repository == '{{ cookiecutter.github_host_account }}/{{ cookiecutter.repo_name }}'" | ||
| runs-on: {{ '${{ matrix.os }}' }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [macOS-latest, ubuntu-latest, windows-latest] | ||
| mdanalysis-version: ["latest", "develop"] | ||
| python-version: ["3.10", "3.11", "3.12"] | ||
| exclude: | ||
| # Entries here exclude particular combinations of the matrix | ||
| # Edit or remove as particular combinations come into or out of date | ||
| # Below we exclude runs with the latest release and Python 3.12 | ||
| - mdanalysis-version: "latest" | ||
| python-version: "3.12" | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
@@ -123,11 +113,22 @@ jobs: | |
| file: coverage.xml | ||
| name: codecov-{{ '${{ matrix.os }}' }}-py{{ '${{ matrix.python-version }}' }} | ||
| verbose: True | ||
| # to upload coverage reports, set a secret called CODECOV_TOKEN | ||
|
There was a problem hiding this comment. Do we have a set of setup instruction docs somewhere where we can put this? (not in this PR but let's raise an issue to get that done at some point :) ) |
||
| # in the repository settings | ||
| # (Obtain this from the Codecov website after setting up the repository there) | ||
| token: {{ '${{ secrets.CODECOV_TOKEN }}' }} | ||
|
There was a problem hiding this comment. I think there's a thing with codecov v4 about this - not sure if we should/want to bump up the version (it might make things break even more!) |
||
| # To fail the CI if there's an error, keep this set to true | ||
| # If repository forks need to run CI, you may need to set this to false | ||
| # Forks can't access the CODECOV_TOKEN secret, | ||
| # and a failed upload registers as an error | ||
| fail_ci_if_error: true | ||
| # use OpenID Connect (OIDC) if you have this enabled -- this will ignore | ||
| # the `token` argument above | ||
| use_oidc: true | ||
|
There was a problem hiding this comment. Are the cookiecutter tests currently failing because this is set to true? There was a problem hiding this comment. Follow up: should this be true by default? There was a problem hiding this comment. Probably related; TIL There was a problem hiding this comment. They're currently failing because of the issues solved in #115! I did test that the fix in #115 resolves this. The codecov action currently gets edited on the fly so failure is ignored.
Interesting, the logs seemed to indicate that codecov was picking up the OIDC token and using it to connect.
I would assume that OIDC is a better means of validation than the plain CODECOV token, if users can do so -- that being said I'm not quite sure how it well it works for forks. I gave it a try just in case it magically helped the upload. Happy to remove and look at it more in detail later for a simpler PR. |
||
|
|
||
|
|
||
| pylint_check: | ||
| if: "github.repository == '{{ cookiecutter.github_host_account }}/{{ cookiecutter.repo_name }}'" | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
|
|
@@ -136,7 +137,7 @@ jobs: | |
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install Pylint | ||
| run: | | ||
|
|
@@ -153,16 +154,15 @@ jobs: | |
|
|
||
| pypi_check: | ||
| if: "github.repository == '{{ cookiecutter.github_host_account }}/{{ cookiecutter.repo_name }}'" | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can be bothered, there's a few action versions that could be bumped up here (upload, download, and checkout can all go to v4, setup-miniconda I think would be good to bump to v3 [I know it doesn't play nice with macos-latest osx-arm64 runners])