Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ConverterBase to the converters.base? #3404

Closed
IAlibay opened this issue Aug 25, 2021 · 4 comments · Fixed by #4253
Closed

Move ConverterBase to the converters.base? #3404

IAlibay opened this issue Aug 25, 2021 · 4 comments · Fixed by #4253

Comments

@IAlibay
Copy link
Member

IAlibay commented Aug 25, 2021

Just having a look at things, and I realise that ConverterBase essentially is just a small subclass of IOBase, but I wonder if it might make more sense to have that in converters.base so that it's more logically situated?

@orbeckst
Copy link
Member

yes – I noticed it when I was updating the docs for 2.0

@orbeckst
Copy link
Member

Of course, we'll need to have a deprecated shim in it's old place until 3.0.

@orbeckst
Copy link
Member

I'll just say that we want to do this and remove the proposal tag.

@orbeckst
Copy link
Member

@ianmkenney please make sure that this issue is also on your TODO list. Thanks.

ianmkenney added a commit that referenced this issue Aug 29, 2023
* ConverterBase moved from coordinates/base.py to converters/base.py
* Added tests for deprecation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants