New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests checking instance of `Backend` when progressbar is supposed to be displayed #4657

Closed

marinegor opened this issue Aug 16, 2024 · 0 comments · Fixed by #4773

Labels

parallelization

Contributor

marinegor commented Aug 16, 2024

Piece of code:

mdanalysis/package/MDAnalysis/analysis/base.py

Lines 770 to 774 in f6672ff

    
           if ((progressbar_kwargs or verbose) and  
        
               not (backend == "serial" or  
        
               issubclass(backend, BackendSerial) or 
        
               isinstance(backend, BackendSerial))): 
        
               raise ValueError("Can not display progressbar with non-serial backend")

Currently tests don't cover that.

yuxuanzhuang added the parallelization label

talagayev mentioned this issue

Addition of isInstance test of BackendSerial #4773

Merged

5 tasks

RMeli closed this as completed in #4773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment