Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of isInstance test of BackendSerial #4773

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

talagayev
Copy link
Member

@talagayev talagayev commented Oct 29, 2024

Fixes #4657

Changes made in this Pull Request:

  • Addition of test_instance_serial_backend to test_base.py to check that the function works and the instance is correct

Currently I just create a variable of BackendSerial for serial_backend , which I use in FrameAnalysis(u.trajectory).run to display that it runs with the backend=serial_backend and also then check the correct instance of serial_backend

I wasn't sure here if I should check the instance of backend of the run() in FrameAnalysis(u.trajectory).run(backend=serial_backend), since then I would need to modify the code to get the instance of backend from run()

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4773.org.readthedocs.build/en/4773/

Addition of test for serial backend instance
@pep8speaks
Copy link

pep8speaks commented Oct 29, 2024

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-13 19:57:25 UTC

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (e776f12) to head (7d0dc7a).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4773      +/-   ##
===========================================
- Coverage    93.66%   93.29%   -0.38%     
===========================================
  Files          177      189      +12     
  Lines        21726    22808    +1082     
  Branches      3052     3055       +3     
===========================================
+ Hits         20349    21278     +929     
- Misses         930     1071     +141     
- Partials       447      459      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Adjusted test_instance_serial_backend to test through pytest raise ValueError
@talagayev talagayev requested a review from RMeli November 13, 2024 21:04
@RMeli RMeli self-assigned this Nov 20, 2024
@RMeli
Copy link
Member

RMeli commented Nov 20, 2024

I restarted the failing job. The timeout is a known issue unfortunately.

@RMeli RMeli merged commit 4e42f7a into MDAnalysis:develop Nov 20, 2024
23 of 24 checks passed
@talagayev talagayev deleted the test_backend_instance branch November 20, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests checking instance of Backend when progressbar is supposed to be displayed
3 participants