Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parallelization in analysis.dihedrals #4682

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Aug 23, 2024

Fixes #4673

Changes made in this Pull Request:

  • parallelized Dihedral, Ramachandran, Janin
  • added tests (including fixtures in analysis/conftest.py)
  • update CHANGELOG

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4682.org.readthedocs.build/en/4682/

- fix #4673
- parallelized Dihedral, Ramachandran, Janin
- added tests (including fixtures in analysis/conftest.py)
- update CHANGELOG
@pep8speaks
Copy link

pep8speaks commented Aug 23, 2024

Hello @orbeckst! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 430:80: E501 line too long (80 > 79 characters)

Line 114:1: W293 blank line contains whitespace

Line 46:5: E303 too many blank lines (2)
Line 61:80: E501 line too long (80 > 79 characters)
Line 106:80: E501 line too long (92 > 79 characters)
Line 114:80: E501 line too long (82 > 79 characters)

Line 270:80: E501 line too long (105 > 79 characters)
Line 284:80: E501 line too long (105 > 79 characters)

Comment last updated at 2024-09-26 01:12:30 UTC

Copy link

github-actions bot commented Aug 23, 2024

Linter Bot Results:

Hi @orbeckst! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/11043710893/job/30678437633


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (8939b3e) to head (8fa8d5f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4682      +/-   ##
===========================================
- Coverage    93.54%   93.52%   -0.03%     
===========================================
  Files          173      185      +12     
  Lines        21439    22517    +1078     
  Branches      3983     3985       +2     
===========================================
+ Hits         20056    21058    +1002     
- Misses         929     1004      +75     
- Partials       454      455       +1     
Flag Coverage Δ
93.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package/CHANGELOG Outdated Show resolved Hide resolved
Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com>
@orbeckst
Copy link
Member Author

@yuxuanzhuang could you please shepherd the PR to completion? Thanks!

(When you squash-merge, please write a nice log message such as

* Fixes #4673
* Changes made in this Pull Request:
    - parallelized Dihedral, Ramachandran, Janin
    - added tests (including fixtures in analysis/conftest.py)
    - update CHANGELOG

Co-authored: ...

and keep the co-author line(s), in particular @talagayev ! Thanks!)

Copy link
Contributor

@yuxuanzhuang yuxuanzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank @talagayev for your help as well!

@yuxuanzhuang yuxuanzhuang merged commit 84ee67b into develop Sep 27, 2024
22 of 23 checks passed
@talagayev
Copy link
Member

Nice, happy to help :)

@RMeli RMeli deleted the parallel-dihedrals branch September 27, 2024 12:26
RMeli pushed a commit to RMeli/mdanalysis that referenced this pull request Oct 3, 2024
* fix MDAnalysis#4673
* Changes made in this Pull Request:
    - parallelized Dihedral, Ramachandran, Janin
    - added tests (including fixtures in analysis/conftest.py)
    - update CHANGELOG

Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDAnalysis.analysis.dihedrals: Implement parallelization or mark as unparallelizable
4 participants