-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added parallelization in analysis.dihedrals #4682
Conversation
- fix #4673 - parallelized Dihedral, Ramachandran, Janin - added tests (including fixtures in analysis/conftest.py) - update CHANGELOG
Hello @orbeckst! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-26 01:12:30 UTC |
Linter Bot Results:Hi @orbeckst! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4682 +/- ##
===========================================
- Coverage 93.54% 93.52% -0.03%
===========================================
Files 173 185 +12
Lines 21439 22517 +1078
Branches 3983 3985 +2
===========================================
+ Hits 20056 21058 +1002
- Misses 929 1004 +75
- Partials 454 455 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com>
@yuxuanzhuang could you please shepherd the PR to completion? Thanks! (When you squash-merge, please write a nice log message such as
and keep the co-author line(s), in particular @talagayev ! Thanks!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank @talagayev for your help as well!
Nice, happy to help :) |
* fix MDAnalysis#4673 * Changes made in this Pull Request: - parallelized Dihedral, Ramachandran, Janin - added tests (including fixtures in analysis/conftest.py) - update CHANGELOG Co-authored-by: Valerij Talagayev <82884038+talagayev@users.noreply.github.com>
Fixes #4673
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4682.org.readthedocs.build/en/4682/