Remove GSD from optional test dependencies #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Investigate rdkit issue * Update azure-pipelines.yml * fix numpy 2.0 import block * fix imports
- fix MDAnalysis#4680 - PCA explicitly marked as not parallelizable (at least not with simple split-apply-combine) - add tests - update CHANGELOG
Linter Bot Results:Hi @yuxuanzhuang! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4707 +/- ##
===========================================
- Coverage 93.87% 93.52% -0.36%
===========================================
Files 173 185 +12
Lines 21428 22494 +1066
Branches 3980 3980
===========================================
+ Hits 20116 21038 +922
- Misses 858 1002 +144
Partials 454 454 ☔ View full report in Codecov by Sentry. |
|
Wow is that a green test matrix! |
hmacdope
approved these changes
Sep 10, 2024
RMeli
pushed a commit
to RMeli/mdanalysis
that referenced
this pull request
Oct 3, 2024
* Fixed high dimensional GroupBase indexing. * fixed pep8 issues * Removed sanitisation * Fix MDAnalysis#4687 -- rdkit values in azure CI (MDAnalysis#4688) * Investigate rdkit issue * Update azure-pipelines.yml * fix numpy 2.0 import block * fix imports * mark analysis.pca.PCA as not parallelizable (MDAnalysis#4684) - fix MDAnalysis#4680 - PCA explicitly marked as not parallelizable (at least not with simple split-apply-combine) - add tests - update CHANGELOG * disable gsd * disable gsd in azure * reduce timeout and set logical * fix azure * restore timeout to 200 --------- Co-authored-by: Matthew Davies <128810112+MattTDavies@users.noreply.github.com> Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com> Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4209
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4707.org.readthedocs.build/en/4707/