Addition of pytest case coverage of backend and AnalysisBase.run() using different n_workers values

[talagayev]

Fixes #4649

Adds the coverage of the ValueError case, where backend and AnalysisBase.run() have
different values for n_workers

Changes made in this Pull Request:

• Added of test_n_workers_conflict_raises_value_error in test_base.py to cover cases, where
  both backend and AnalysisBase.run() have different values of n_workers

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

Developers certificate of origin

• I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

---

📚 Documentation preview 📚: https://mdanalysis--4768.org.readthedocs.build/en/4768/

[pep8speaks]

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-26 23:17:06 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (7e521de) to head (7b2b944).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4768      +/-   ##
===========================================
- Coverage    93.67%   93.66%   -0.02%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20367    21362     +995     
- Misses         928     1000      +72     
+ Partials       447      446       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hmacdope]

LGTM thanks @talagayev

[talagayev]

How is it now the case, would this and the other PR, which also only adresses a pytest be currently frozen until the release of 2.8.0 and merged after the release of 2.8.0?

[talagayev]

LGTM thanks @talagayev

Happy to help :)

[hmacdope]

How is it now the case, would this and the other PR, which also only adresses a pytest be currently frozen until the release of 2.8.0 and merged after the release of 2.8.0?

I believe we are in a code freeze for now, can be merged if we like but I will leave at discretion of release manager, @IAlibay.

[IAlibay]

If it's not on the 2.8 milestone, I would prefer it if we didn't merge it until after the release.

[IAlibay]

Same as the other PR.

[talagayev]

If it's not on the 2.8 milestone, I would prefer it if we didn't merge it until after the release.

Yup sounds good :)

Comments have been adressed, but for some reason I can't ask a re-review.

[talagayev]

Could it possibly connected that I asked for a re-review that @RMeli you cannot ask for a re-review?