-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of SugarSelection #4790
base: develop
Are you sure you want to change the base?
Conversation
Implementation of SugarSelection with the known abbreviations and aglycans obtained from the glycam webserver
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-15 22:28:53 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4790 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 177 189 +12
Lines 21742 22816 +1074
Branches 3055 3055
===========================================
+ Hits 20365 21366 +1001
- Misses 930 1003 +73
Partials 447 447 ☔ View full report in Codecov by Sentry. |
pep fix 1
Added test files
Added tests for sugar selection
pep fix
@hmacdope I will ping you here since you were one of the participants in the discussion that initiated the Issue that this PR is covering. The main problem that I see currently, would be that the GLYCAM Abbreviations for the sugars due to the combinations have quite a lot of different names/abbreviations. Some of them could lead to tricky cases, with the Allose Nomenclature having I checked the RCSB-PDB and found only one case, where a unique ligand was called As for the coverage, while looking at the PDBs in RCSB-PDB it covers |
Fixes #4563
Changes made in this Pull Request:
SugarSelection
class that allows the selection of sugars throughthe access of known PDB, CHARMM and GLYCAM abbreviations
GLYCAM
andSUGAR_PDB
files inMDAnalysisTest.data
test_sugar_glycam_selection()
andtest_sugar_pdb_selection
in
test_atomselections.py
Currently I used the following abbreviations:
https://glycam.org/docs/othertoolsservice/2016/06/09/3d-snfg-list-of-residue-names/index.html
In addition of using the GLYCAM Webserver to obtain the known Sugar abbreviations and also
included the aglycans that I obtained from the GLYCAM Weberserver.
The Pytest Files were retrieved from RCSB-PDB and the GLYCAM-Webserver:
https://glycam.org/
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4790.org.readthedocs.build/en/4790/