Transfer of fasteners dependency to fielock
#4800
Draft
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes fasteners to filelock dependency
changes fasteners to filelock dependency
changes in the action the fasteners dependency to filelock
adjusted input fasteners to filelock
changed fasteners to filelock
changed fasteners to filelock
changed fasteners to filelock
talagayev
changed the title
fasteners dependency to fielock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4800 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 177 189 +12
Lines 21742 22808 +1066
Branches 3055 3055
===========================================
+ Hits 20365 21358 +993
- Misses 930 1003 +73
Partials 447 447 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
test _read_offsets adjustment
modification of test_offset_lock_created to adjust to new dependency
returned the warning and read_offsets for tests
required removal of asser_equal to not get the error, since now the files, dont't end with lock and the removal of the end would be a duplicate of the other assert_equal
|
@yuxuanzhuang I would ping you since you worked on the and if they require modification. Other than that the only problem that I encounter now is the Azure failing, due to Windows runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4797
Changes made in this Pull Request:
fastenersdependency fromXDR.pyand all installation filesfilelockas an replacement dependency offastenersPR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4800.org.readthedocs.build/en/4800/