Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Start 2.9.0-dev0 #4803

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[HOLD] Start 2.9.0-dev0 #4803

merged 1 commit into from
Nov 26, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 26, 2024

If this comes back not red (except the 3.9 runners.. they are still pulling old MDAnalysis): https://github.com/MDAnalysis/mdanalysis/actions/runs/12039544989/job/33567570077

Then we're good to go.

PR Checklist

  • CHANGELOG updated?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4803.org.readthedocs.build/en/4803/

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (46be788) to head (d62dc0a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4803      +/-   ##
===========================================
- Coverage    93.67%   93.65%   -0.02%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20366    21360     +994     
- Misses         928     1001      +73     
+ Partials       448      447       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IAlibay
Copy link
Member Author

IAlibay commented Nov 26, 2024

Alright I'm calling this one as "ok" - only thing that's failing is the py3.9 pipelines and they are running on MDA 2.7.0.

@IAlibay IAlibay merged commit 7e521de into develop Nov 26, 2024
22 of 26 checks passed
@IAlibay IAlibay deleted the start-2.9.0 branch November 26, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants