Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to --tedpca option #1066

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Changes to --tedpca option #1066

wants to merge 6 commits into from

Commits on Mar 23, 2024

  1. Changes to --tedpca option verification & documentation 

    Changes to facilitate the selection of all non-void PCA components by requesting 100% of variance.
    @Lestropie
    Lestropie committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    55aee07 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Merge branch 'ME-ICA:main' into tedpca_option

    @BahmanTahayori
    BahmanTahayori authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e3c562f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'ME-ICA:main' into tedpca_option

    @BahmanTahayori
    BahmanTahayori authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ba79dce View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. --tedpca option: Forbid floating-point value of 1.0 

    Partial reversion of 55aee07 as discussed in ME-ICA#1066.
These changes forbid the request to preserve 100% of variance by specifying "--tedpca 1.0"; it is intended to in the future facilitate this sort of operation through other means.
    @Lestropie
    Lestropie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5fa9cb3 View commit details
    Browse the repository at this point in the history

  2. tedana/workflows/parser_utils.py: Formatting fix

    @Lestropie
    Lestropie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e81badf View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. check_tedpca_value(): Fix docstring 

    Partial reversion of 55aee07 in that requesting a floating-point value of 1.0, being 100% of variance, is no longer permitted.
    @Lestropie
    Lestropie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f5a3683 View commit details
    Browse the repository at this point in the history