Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mod Update Checks after Mod Import #263

Closed
Herobrine24 opened this issue Aug 25, 2021 · 7 comments
Closed

Remove Mod Update Checks after Mod Import #263

Herobrine24 opened this issue Aug 25, 2021 · 7 comments
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Milestone

Comments

@Herobrine24
Copy link
Contributor

If you bulk download/import mods one after another, it will always bring up the mod update prompt after you choose to import or install a mod, sometimes even stack them.

@Mgamerz
Copy link
Member

Mgamerz commented Sep 13, 2021

While I won't be disabling the update check, what I originally meant for this feature was to make it check that the imported mod was up to date, as sometimes even I put out mods that get a tiny update (since uploading to nexus is a lot of effort at times). I'll have this fixed so it's scoped only to the mod(s) that were imported.

@Mgamerz Mgamerz added the bug Something isn't working label Sep 13, 2021
@Mgamerz Mgamerz added the Needs validation Feature is implemented and needs testing and/or feedback label Mar 1, 2022
@Mgamerz
Copy link
Member

Mgamerz commented Mar 1, 2022

I'm pretty sure this is implemented in the current 8.0 beta code but I need to do some more testing to ensure it still runs.

@Mgamerz Mgamerz added this to the 8.0 milestone Mar 10, 2022
Mgamerz added a commit that referenced this issue Mar 11, 2022
… a bit for #289 for some scenarios (modmaker, mixins). Coalesce mod update checks as part of #263 so only one check is performed
@C0d3Deo
Copy link

C0d3Deo commented Jun 26, 2022

While I won't be disabling the update check, what I originally meant for this feature was to make it check that the imported mod was up to date, as sometimes even I put out mods that get a tiny update (since uploading to nexus is a lot of effort at times). I'll have this fixed so it's scoped only to the mod(s) that were imported.

This creates a burden for players who choose to use texture mods for their playthrough, which obviously doesn't allow further mod manipulation, but who like to use the mod manager to skip the game launcher. Please reconsider making this optional

@Mgamerz
Copy link
Member

Mgamerz commented Jun 26, 2022

The update check is for mods in the library, not for what's installed, which the only thing texture modding affects.

@C0d3Deo
Copy link

C0d3Deo commented Jun 26, 2022

The update check is for mods in the library, not for what's installed, which the only thing texture modding affects.

Are you saying this is not the same issue this thread is pertaining to or that its simply not an "issue" at all? I don't understand how tyour response changes the situation considering you have to put the mods into the library to install them. I have to use ME3Tweaks to install mods. Once mods are installed it will check every time its opened for an update for every single mod listed no matter how incremental, and won't stop giving an initial popup, stopping me from launching the game like I want, until I close the box. I can understand the benefit to having it check by default, but to make it a forced, unremovable option seems counter to the spirit of the mod, putting an inconvenience players that literally CAN'T update mods anymore because of the textures system.

@Mgamerz
Copy link
Member

Mgamerz commented Jun 26, 2022

Updates are checked for once a day. In Mod Manager 7 it checked for updates to all mods on any mod import, which is what this bug report is about. In Mod Manager 8 it only checks for updates to the mod that has been imported.

You can update your mods in your library without affecting your game. The library and the game are two completely separate entities. The update check is not checking for updates to your installed mods. Personally I don't think having to click through a box once a day is that inconvenient.

@Mgamerz
Copy link
Member

Mgamerz commented Aug 14, 2022

This should be more reliable and consistent now in Mod Manager 8.

@Mgamerz Mgamerz closed this as completed Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Projects
None yet
Development

No branches or pull requests

3 participants