Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Maintenance Windows with "Offset Days" Are Not Reported #31

Closed
mchippy opened this issue Dec 1, 2023 · 9 comments
Closed

[BUG] Maintenance Windows with "Offset Days" Are Not Reported #31

mchippy opened this issue Dec 1, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@mchippy
Copy link

mchippy commented Dec 1, 2023

When a collection utilizes a maintenance window such as "Occurs 4 day(s) after the Fourth Tuesday of every month," the next maintenance window is not calculated in the report and is marked as not having a service window defined.

Steps to reproduce the behavior:

  1. Create a maintenance window using the "offset days" function
  2. Run report.
  3. Observe a lack of dates in the "Next Maintenance Window" column

I would expect to see the next maintenance window calculated in this column.

The maintenance window:
image

The SRS report:
image

SystemCenterDudes report detailing maintenance windows;
image

Desktop (please complete the following information):

  • OS: Windows Server 2016
  • Browser: Edge
  • Version 116.0.1938.62

After changing the maintenance window to not utilize the offset days, the Next Maintenance Window column is properly calculated and displayed.

@mchippy mchippy added the bug Something isn't working label Dec 1, 2023
@Ioan-Popovici
Copy link
Member

Ioan-Popovici commented Dec 4, 2023

Yeah, when this was created offset days didn't existed.

About that report, I can display the content of the MW pretty easily, calculating the Next MW is a bit harder.

I'll look into it, see if I can figure a way to include the offset days into the calculation.

@mchippy
Copy link
Author

mchippy commented Dec 4, 2023

Yeah, when this was created offset days didn't existed. I'll look into it...

I figured as such. Thanks for looking at it! This is a very nice reporting dashboard you’ve created.

@Ioan-Popovici
Copy link
Member

I've looked into it but there's zero documentation on how this added in the schedule token.

I'll keep trying, maybe I can reverse engineer it. I can see the schedule token changing in a specific way but I don't know how to interpret it...

Ioan-Popovici added a commit that referenced this issue Jan 17, 2024
## 5.0.4b - 2024–01-17

* Added `OffsetDays` #31
@Ioan-Popovici
Copy link
Member

@mchippy, can you maybe test this version

It was hard to find the value as it was not documented. I have no environment in which I can test this at the moment.

@Ioan-Popovici Ioan-Popovici added the help wanted Extra attention is needed label Jan 17, 2024
Ioan-Popovici added a commit that referenced this issue Jan 30, 2024
* Fixed `Next Maintenance Window` if using `Offset Days` maintenance windows #31.
@Ioan-Popovici
Copy link
Member

Fixed in v5.0.4, closing issue

@Ioan-Popovici Ioan-Popovici reopened this Feb 2, 2024
Ioan-Popovici added a commit that referenced this issue Feb 2, 2024
# Changelog for MEM.Zone-Dashboards

## 5.0.5 - 2024-02-02

* Fixed variable bug `Next Maintenance Window` if using `Offset Days` maintenance windows (issue #31).
@Ioan-Popovici
Copy link
Member

Changelog for MEM.Zone-Dashboards

5.0.5 - 2024-02-02

@Ioan-Popovici Ioan-Popovici removed the help wanted Extra attention is needed label Feb 2, 2024
@Ioan-Popovici Ioan-Popovici reopened this Feb 21, 2024
@Ioan-Popovici
Copy link
Member

image

The maintenance window shows up for tomorrow instead of today.

Reported by @mchippy

@Ioan-Popovici
Copy link
Member

CleanShot 2024-02-21 at 10 20 09@2x

CleanShot 2024-02-21 at 10 20 26@2x

I can't replicate the issue, this is within one minute of an occurring maintenance window...

@Ioan-Popovici
Copy link
Member

Closing, seems to be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants