Make num comply (mostly) with Fortran 2008 standard
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
num: make test src f2008 standard compliant
pmocz
changed the title
num comply (mostly) with Fortran 2008 standardnum comply (mostly) with Fortran 2008 standard
pmocz
reviewed
Aug 7, 2024
|
Are we good to merge this? |
|
I think so? I'm not sure if we want to wait until after the release. I personally don't mind but wouldn't mind at least another dev chipping in. |
Probably best to merge this in right after release actually, since we'd like to get the release out very soon and even though we tested this branch it doesn't add too much to users (yet, without the other successive PRs which should be left for after the release) |
Merged
|
Merging now that we already have the 24.08.1 release branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of @VincentVanlaer's PR #696 (thanks Vincent!), which already made
num/testcomply with the Fortran 2008 standard. The rest ofnumis now compiled with a Fortran 2008 flag so the aim is to reduce the number of warnings before merging this intomain.We should make sure we can still build with
ifortbefore merging.