forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core, eth, internal/ethapi: create access list RPC API (ethereum#22550)
* core/vm: implement AccessListTracer * eth: implement debug.createAccessList * core/vm: fixed nil panics in accessListTracer * eth: better error messages for createAccessList * eth: some fixes on CreateAccessList * eth: allow for provided accesslists * eth: pass accesslist by value * eth: remove created acocunt from accesslist * core/vm: simplify access list tracer * core/vm: unexport accessListTracer * eth: return best guess if al iteration times out * eth: return best guess if al iteration times out * core: docstring, unexport methods * eth: typo * internal/ethapi: move createAccessList to eth package * internal/ethapi: remove reexec from createAccessList * internal/ethapi: break if al is equal to last run, not if gas is equal * internal/web3ext: fixed arguments * core/types: fixed equality check for accesslist * core/types: no hardcoded vals * core, internal: simplify access list generation, make it precise * core/vm: fix typo Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com>
- Loading branch information
3 people
authored
Apr 7, 2021
1 parent
a600dab
commit 9d10856
Showing
10 changed files
with
318 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| // Copyright 2021 The go-ethereum Authors | ||
| // This file is part of the go-ethereum library. | ||
| // | ||
| // The go-ethereum library is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Lesser General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // The go-ethereum library is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Lesser General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Lesser General Public License | ||
| // along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package vm | ||
|
|
||
| import ( | ||
| "math/big" | ||
| "time" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/core/types" | ||
| ) | ||
|
|
||
| // accessList is an accumulator for the set of accounts and storage slots an EVM | ||
| // contract execution touches. | ||
| type accessList map[common.Address]accessListSlots | ||
|
|
||
| // accessListSlots is an accumulator for the set of storage slots within a single | ||
| // contract that an EVM contract execution touches. | ||
| type accessListSlots map[common.Hash]struct{} | ||
|
|
||
| // newAccessList creates a new accessList. | ||
| func newAccessList() accessList { | ||
| return make(map[common.Address]accessListSlots) | ||
| } | ||
|
|
||
| // addAddress adds an address to the accesslist. | ||
| func (al accessList) addAddress(address common.Address) { | ||
| // Set address if not previously present | ||
| if _, present := al[address]; !present { | ||
| al[address] = make(map[common.Hash]struct{}) | ||
| } | ||
| } | ||
|
|
||
| // addSlot adds a storage slot to the accesslist. | ||
| func (al accessList) addSlot(address common.Address, slot common.Hash) { | ||
| // Set address if not previously present | ||
| al.addAddress(address) | ||
|
|
||
| // Set the slot on the surely existent storage set | ||
| al[address][slot] = struct{}{} | ||
| } | ||
|
|
||
| // equal checks if the content of the current access list is the same as the | ||
| // content of the other one. | ||
| func (al accessList) equal(other accessList) bool { | ||
| // Cross reference the accounts first | ||
| if len(al) != len(other) { | ||
| return false | ||
| } | ||
| for addr := range al { | ||
| if _, ok := other[addr]; !ok { | ||
| return false | ||
| } | ||
| } | ||
| for addr := range other { | ||
| if _, ok := al[addr]; !ok { | ||
| return false | ||
| } | ||
| } | ||
| // Accounts match, cross reference the storage slots too | ||
| for addr, slots := range al { | ||
| otherslots := other[addr] | ||
|
|
||
| if len(slots) != len(otherslots) { | ||
| return false | ||
| } | ||
| for hash := range slots { | ||
| if _, ok := otherslots[hash]; !ok { | ||
| return false | ||
| } | ||
| } | ||
| for hash := range otherslots { | ||
| if _, ok := slots[hash]; !ok { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| // accesslist converts the accesslist to a types.AccessList. | ||
| func (al accessList) accessList() types.AccessList { | ||
| acl := make(types.AccessList, 0, len(al)) | ||
| for addr, slots := range al { | ||
| tuple := types.AccessTuple{Address: addr} | ||
| for slot := range slots { | ||
| tuple.StorageKeys = append(tuple.StorageKeys, slot) | ||
| } | ||
| acl = append(acl, tuple) | ||
| } | ||
| return acl | ||
| } | ||
|
|
||
| // AccessListTracer is a tracer that accumulates touched accounts and storage | ||
| // slots into an internal set. | ||
| type AccessListTracer struct { | ||
| excl map[common.Address]struct{} // Set of account to exclude from the list | ||
| list accessList // Set of accounts and storage slots touched | ||
| } | ||
|
|
||
| // NewAccessListTracer creates a new tracer that can generate AccessLists. | ||
| // An optional AccessList can be specified to occupy slots and addresses in | ||
| // the resulting accesslist. | ||
| func NewAccessListTracer(acl types.AccessList, from, to common.Address, precompiles []common.Address) *AccessListTracer { | ||
| excl := map[common.Address]struct{}{ | ||
| from: {}, to: {}, | ||
| } | ||
| for _, addr := range precompiles { | ||
| excl[addr] = struct{}{} | ||
| } | ||
| list := newAccessList() | ||
| for _, al := range acl { | ||
| if _, ok := excl[al.Address]; !ok { | ||
| list.addAddress(al.Address) | ||
| } | ||
| for _, slot := range al.StorageKeys { | ||
| list.addSlot(al.Address, slot) | ||
| } | ||
| } | ||
| return &AccessListTracer{ | ||
| excl: excl, | ||
| list: list, | ||
| } | ||
| } | ||
|
|
||
| func (a *AccessListTracer) CaptureStart(env *EVM, from common.Address, to common.Address, create bool, input []byte, gas uint64, value *big.Int) { | ||
| } | ||
|
|
||
| // CaptureState captures all opcodes that touch storage or addresses and adds them to the accesslist. | ||
| func (a *AccessListTracer) CaptureState(env *EVM, pc uint64, op OpCode, gas, cost uint64, scope *ScopeContext, rData []byte, depth int, err error) { | ||
| stack := scope.Stack | ||
| if (op == SLOAD || op == SSTORE) && stack.len() >= 1 { | ||
| slot := common.Hash(stack.data[stack.len()-1].Bytes32()) | ||
| a.list.addSlot(scope.Contract.Address(), slot) | ||
| } | ||
| if (op == EXTCODECOPY || op == EXTCODEHASH || op == EXTCODESIZE || op == BALANCE || op == SELFDESTRUCT) && stack.len() >= 1 { | ||
| addr := common.Address(stack.data[stack.len()-1].Bytes20()) | ||
| if _, ok := a.excl[addr]; !ok { | ||
| a.list.addAddress(addr) | ||
| } | ||
| } | ||
| if (op == DELEGATECALL || op == CALL || op == STATICCALL || op == CALLCODE) && stack.len() >= 5 { | ||
| addr := common.Address(stack.data[stack.len()-2].Bytes20()) | ||
| if _, ok := a.excl[addr]; !ok { | ||
| a.list.addAddress(addr) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (*AccessListTracer) CaptureFault(env *EVM, pc uint64, op OpCode, gas, cost uint64, scope *ScopeContext, depth int, err error) { | ||
| } | ||
|
|
||
| func (*AccessListTracer) CaptureEnd(output []byte, gasUsed uint64, t time.Duration, err error) {} | ||
|
|
||
| // AccessList returns the current accesslist maintained by the tracer. | ||
| func (a *AccessListTracer) AccessList() types.AccessList { | ||
| return a.list.accessList() | ||
| } | ||
|
|
||
| // Equal returns if the content of two access list traces are equal. | ||
| func (a *AccessListTracer) Equal(other *AccessListTracer) bool { | ||
| return a.list.equal(other.list) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.