Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] sub remark + settings UI #332

Merged
merged 6 commits into from
May 4, 2023
Merged

Conversation

hamid-gh98
Copy link
Contributor

  • Updated subscription remark to include inbound name, similar to when copied from panel.
  • Updated settings.html UI and renamed its file.
  • Moved timezone from other settings to panel configuration.
  • Replaced number input tags with "a-input-number".
  • Updated translations to ensure clarity and consistency.

@MHSanaei
Copy link
Owner

MHSanaei commented May 4, 2023

Hi Hamid-gh98,

I wanted to take a moment to thank you for your recent pull request. Your changes to the subscription remark, UI, and translations have greatly improved the project's overall quality. I also appreciate your attention to detail in updating the input tags and renaming the file.

I enjoyed collaborating with you on this project, and I hope to continue working with you in the future.

Thanks again for your contribution

@MHSanaei MHSanaei merged commit e164c7e into MHSanaei:main May 4, 2023
@hamid-gh98
Copy link
Contributor Author

Hi Hamid-gh98,

I wanted to take a moment to thank you for your recent pull request. Your changes to the subscription remark, UI, and translations have greatly improved the project's overall quality. I also appreciate your attention to detail in updating the input tags and renaming the file.

I enjoyed collaborating with you on this project, and I hope to continue working with you in the future.

Thanks again for your contribution

Dear MHSanaei,

Thank you for taking the time to write to me regarding my recent pull request. I'm delighted to hear that and It was a pleasure working with you.

Thank you once again for your feedback and for giving me the chance to contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants