Skip to content

Fix 'Duplicate Code' issue in simulator\kernel\mars\t\unit_test.cpp #1096

Closed
pavelkryukov opened this issue Oct 2, 2019 · 0 comments · Fixed by #1117
Closed

Fix 'Duplicate Code' issue in simulator\kernel\mars\t\unit_test.cpp #1096

pavelkryukov opened this issue Oct 2, 2019 · 0 comments · Fixed by #1117
Assignees
@M-ximus
Labels
1 Usually one-liner tasks, but may require some deep into infrastructure. code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.

Comments

@pavelkryukov
Copy link
Member

CodeFactor found an issue: Duplicate Code

It's currently on:
simulator\kernel\mars\t\unit_test.cpp:250-265
simulator\kernel\mars\t\unit_test.cpp:267-282
Commit 0f293f1
@pavelkryukov pavelkryukov added 1 Usually one-liner tasks, but may require some deep into infrastructure. code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding. labels Oct 2, 2019
@M-ximus M-ximus mentioned this issue Oct 21, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@M-ximus M-ximus

Labels
1 Usually one-liner tasks, but may require some deep into infrastructure. code Enhances infrastructure or refines, Requires almost no knowledge in CPU microarchitecture. S1 — C++ To solve the issue, you barely need knowledge about CPU microarchitecture, just C++ coding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wraps for open and write to file M-ximus/mipt-mips
2 participants
@pavelkryukov @M-ximus