Use faster C++11 STL container for MIPS ISA

[pavelkryukov]

Currently MIPS ISA is stored in C-style static array. With C++11 we may initialize something like std::list or std::unordered_map during compile-time.

[pavelkryukov]

@TimofeevAlex I would like to see 3 std::unordered_maps. If opcode is 0x0, search is performed over map of R-instructions. If opcode is 0x1, search is performed over map of RI-instructions (so it is a good opportunity to close issues #93 and #137 and get 5 more points!). Otherwise, search is performed over map of I- and J-instructions. You may skip RI-instructions for now, as they are not implemented yet.

[pavelkryukov]

@TimofeevAlex Any progress?

[TimofeevAlex]

I haven't had enough time to do this task yet. I've planned to do it seriously next week. 2017-10-23 17:14 GMT+03:00 Pavel I. Kryukov <notifications@github.com>:

…

@TimofeevAlex <https://github.com/timofeevalex> Any progress? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AevIrzjVY9jgcq-i1B_mtsLEb30i_s04ks5svJ9TgaJpZM4M5QU5> .

-- С уважением, Александр Тимофеев

[pavelkryukov]

@TimofeevAlex Ok, thank you for notification. I advise you to finish it next week as we have a MIPS ISA lecture in the beginning of November, so other guys may implement missing MIPS instructions, creating merge conflicts for you.

[pavelkryukov]

@TimofeevAlex Any progress?

[TimofeevAlex]

I have figured out the code in the project, C++ container and started writing the code. But I am afraid that I won't get in time. 1 Ноя 2017 г. 10:58 пользователь "Pavel I. Kryukov" < notifications@github.com> написал: @TimofeevAlex <https://github.com/timofeevalex> Any progress? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AevIr3rzhuhMNlmKb4jMPq3T3l_HUVl1ks5syCSfgaJpZM4M5QU5> .

[pavelkryukov]

That's great!

I think we should use std::unordered_map here as it has O(1) read time.
Currently we have this:

for ( const auto& entry : isaTable)
{
    bool is_i_R = ( entry.format == FORMAT_R);
    if ( entry.opcode == ident && ( is_i_R == is_R))
    {
          // instruction initialization

And we want to get here (at least, you may do something better. like adding instruction format instead of bool to the key):

const auto& entry = isaTable.find( std::make_pair( opcode, is_R));
if ( entry != isaTable.end())
{
     // instruction initialization

[pavelkryukov]

Feel free to ask questions

[TimofeevAlex]

OK I understood 1 Ноя 2017 г. 20:09 пользователь "Pavel I. Kryukov" < notifications@github.com> написал:

…

Feel free to ask questions — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AevIr_HUlftE97YTEadJhhGqV1Isovmnks5syKXTgaJpZM4M5QU5> .

[pavelkryukov]

One week passed since our previous sync-up. Do you have any updates on the issue?

[pavelkryukov]

One more week passed since our previous sync-up. Do you have any updates on the issue? Kirill is working on #93, he might proceed faster with that issue.

[TimofeevAlex]

I'm going to finish this weekend. 16 Ноя 2017 г. 13:22 пользователь "Pavel I. Kryukov" < notifications@github.com> написал:

…

One more week passed since our previous sync-up. Do you have any updates on the issue? Kirill is working on #93 <#93>, he might proceed faster with that issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AevIryXY_Ki19EyKUBM8EvaXlxKr5DM0ks5s3AzcgaJpZM4M5QU5> .