Added root Makefile with compiler and build options #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelkryukov
reviewed
Apr 5, 2017
perf_sim/Makefile
Outdated
| @@ -47,7 +33,7 @@ main.o: main.cpp | |||
| $(CXX) $(CXXFLAGS) -c $< $(INCL) | |||
|
|
|||
| # | |||
| # Enter to remove all created files. | |||
| # Enter to remove all created files | |||
There was a problem hiding this comment.
Added now. 147e15d
|
Can you please squash all (or at least related) commits next time before sending pull request to simplify review process? |
|
Yes, of course. Sorry, I'm just relatively new to the system and don't perceive it from the reviewers view. It's clear that it's quite inconvenient for you to review such a mess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether it is OK to add all the paths into the root Makefile (many
vpathandINCLdirs), as in case there are headers with same name, It will not work properly, and such an overhead might slow down the build a little.But I believe for relatively small
mips-mipsit's quite acceptable for now, as the build takes few seconds and all the headers are named differently and everything just works.This should accomplish #48