Skip to content

Commit

Permalink
Don't use dllexport/dllimport for statically-linked FLAC on win32.
Browse files Browse the repository at this point in the history
The module is being built into a DLL, but we do not want FLAC symbols
to be either exported or imported (in the same way we use
-fvisibility=hidden on ELF systems.)  Defining FLAC__NO_DLL causes
FLAC_API to be empty.
  • Loading branch information
Benjamin Moody committed Aug 2, 2024
1 parent 3f792cc commit 54454ec
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def _flac_options():

define_macros = [
('HAVE_CONFIG_H', '1'),
('FLAC__NO_DLL', '1'),
('PLIBFLAC_FLAC_VERSION', '"%s"' % version),
('PLIBFLAC_WORDS_BIGENDIAN', str(int(sys.byteorder == 'big'))),
]
Expand Down

0 comments on commit 54454ec

Please sign in to comment.