Skip to content

Commit

Permalink
Sets link to hold panel to open in new tab
Browse files Browse the repository at this point in the history
** Why are these changes being introduced:

* The link named "See details in admin interface" on the thesis
  processing form, in the status panel, has an undefined target. Staff
  users have requested that this link be forced to open in a new tab.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ETD-374

** How does this address that need:

* This explicitly sets the target of this link to be `_blank`, which
  will force well-designed browsers to open the link in a new tab.

** Document any side effects to this change:

* It will no longer be possible to open these links in the same tab.
  • Loading branch information
matt-bernhardt committed Jul 12, 2021
1 parent 85a3312 commit ef0428a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/views/thesis/process_theses.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
label_html: { style: 'width: 50%' },
input_html: { class: 'disabled', style: 'width: 40%', value: f.object.active_holds?? 'Yes' : 'No' },
hint_html: { style: 'display: block' },
hint: link_to('See details in admin interface',admin_thesis_path(f.object)) %>
hint: link_to('See details in admin interface', admin_thesis_path(f.object), target: :_blank) %>

</li>
<li>
Expand Down

0 comments on commit ef0428a

Please sign in to comment.