Use Archivematica accession numbers in SIP AWS keys #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
reviewed
Sep 25, 2023
JPrevost
requested changes
Sep 26, 2023
JPrevost
approved these changes
Sep 26, 2023
Why these changes are being introduced: Artefactual has requested that our AWS keys for SIPs should include an Archivematica accession number. This will allow them to automate processing of thesis SIPs. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-593 How this addresses that need: This builds on previous work to rename the AWS key for a given thesis' SIP using the accession number for that thesis. It also adds a check for the presence of an accession number to the `baggable_thesis?` method, in the unlikely (but possible) event that someone tries to create a SIP for an unpublished thesis via the Rails console. Side effects of this change: This will only affect theses preserved _after_ this change is deployed in production. We do not have a plan to retroactively change AWS keys, and stakeholders understand and have agreed to this.
jazairi
force-pushed
the
etd-593-update-aws-keys
branch
from
34ef4b7 to
4bd7908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Artefactual has requested that our AWS keys for SIPs should include an Archivematica accession number. This will allow them to automate processing of thesis SIPs.
Relevant ticket(s):
How this addresses that need:
This builds on previous work to rename the AWS key for a given thesis' SIP using the accession number for that thesis.
Side effects of this change:
This will only affect theses preserved after this change is deployed in production. We do not have a plan to retroactively change AWS keys, and stakeholders understand and have agreed to this.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO