Notify processors to create new Archivematica accessions #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The codeclimate criticism echoes my own concern when I started looking at the registrar import job. I do think it's fixable, but I'm not sure that abstracting all of that code into tiny methods will make it any more readable. I'd welcome reviewer feedback on this. |
JPrevost
approved these changes
Oct 3, 2023
Why these changes are being introduced: If a processor adds an Archivematica Accession for a thesis that is otherwise ready for publication, they will need to update that thesis before its publication status switches over to 'Publication review'. This could become substantially time consuming when working with large batches of theses. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-596 How this addresses that need: This creates new Degree Period records during the Registrar Data Import job, using a similar pattern to how we create new Degree and Department records. It also adds new Degree Period records to the mailer, so that processors can proactively create Archivematica Accession records for them. Side effects of this change: * One of the registrar data fixtures has been updated so that more than one degree date will be created in the relevant test. * Rubocop identified and fixed a couple of issues unrelated to this change.
jazairi
force-pushed
the
etd-640-accession-reporting
branch
from
32af509 to
5b529d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
If a processor adds an Archivematica Accession for a thesis that is otherwise ready for publication, they will need to update that thesis before its publication status switches over to 'Publication review'. This could become substantially time consuming when working with large batches of theses.
Relevant ticket(s):
How this addresses that need:
This creates new Degree Period records during the Registrar Data Import job, using a similar pattern to how we create new Degree and Department records. It also adds new Degree Period records to the mailer, so that processors can proactively create Archivematica Accession records for them.
Side effects of this change:
Rubocop identified and fixed a couple of issues unrelated to this change.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO