Theses not publishable with duplicate filenames #1236
Conversation
| assert_equal true, thesis.departments_have_dspace_name? | ||
| assert_equal true, thesis.degrees_have_types? | ||
| assert_equal true, thesis.accession_number.present? | ||
| assert thesis.valid? |
There was a problem hiding this comment.
These changes are just to use the preferred syntax for asserting truthy/falsey:
| assert thesis.departments_have_dspace_name? | ||
| assert thesis.degrees_have_types? | ||
| assert thesis.accession_number.present? | ||
| assert thesis.unique_filenames?(thesis) |
There was a problem hiding this comment.
This is the only new assertion in this section.
There was a problem hiding this comment.
I don't have time for a thorough review of this today (i.e., I have not verified the changes locally), but from what I can tell it looks like it solves the problem. If you'd like, I can give it a closer look on Tuesday either pre- or post-merge.
I still think we need a processor workflow to rename files and probably one or more new file purposes, but I think we agree that should be follow-on work and this should merge to avoid any additional issues in prod.
Speaking of which, we cannot deploy to prod until this ticket closes.
Why are these changes being introduced: * we cannot send theses to preservation with duplicate filenames * preservation is a step after publication, so doing this check before publication will ensure we don't publish things we can't preserve Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-648 How does this address that need: * Moves the baggable? logic to it's own module * Inlcudes that module in both SIP and Thesis models * Uses the unique_filenames? check as part of the thesis publication checks * Adds a visual display to the processor checklist to indicate if filenames are unique Document any side effects to this change: * There is no direct mechanism in the application to allow a processor to resolve duplicate filename issues
JPrevost
force-pushed
the
etd648-baggable-thesis-for-publication
branch
from
91aa546 to
2f3faf3
Compare
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
YES