Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop 1.56.3 → 1.57.0 (minor) #1239

Closed
wants to merge 1 commit into from
Closed

Update rubocop 1.56.3 → 1.57.0 (minor) #1239

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 12, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.56.3 → 1.57.0) · Repo · Changelog

Release Notes

1.57.0

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. (@koic)
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@koic)
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@koic)

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@koic)
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@koic)
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@koic)
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@knu)
  • #12198: Fix an error for flip-flop with beginless or endless ranges. (@koic)
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@koic)
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@koic)
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@koic)
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@koic)
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@koic)
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@K-S-A)

Changes

  • #12235: Enable auto parallel inspection when config file is specified. (@aboutNisblee)
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@koic)
  • #12128: Make Style/GuardClause aware of define_method. (@koic)
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@koic)
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@koic)
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@koic)
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@koic)

1.56.4

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@koic)
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@koic)
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@koic)
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@koic)
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@koic)
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@koic)
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@ydah)
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@koic)

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 70 commits:

↗️ parser (indirect, 3.2.2.3 → 3.2.2.4) · Repo · Changelog

Release Notes

3.2.2.4 (from changelog)

API modifications:

  • bump Racc to 1.7.1 (#930) (Koichi ITO)

Bugs fixed:

  • Fix an error for flip-flop with beginless or endless ranges (#946) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

↗️ regexp_parser (indirect, 2.8.1 → 2.8.2) · Repo · Changelog

Release Notes

2.8.2 (from changelog)

Fixed

  • handle a corner case where parsing redundant number escapes raised an error
    • e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99
    • thanks to Markus Schirp for the report

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

Release Notes

2.5.0 (from changelog)

  • Unicode 15.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 12, 2023
@mitlib mitlib temporarily deployed to thesis-submit-pr-1239 October 12, 2023 12:20 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.371%. remained the same when pulling 7b33fa9 on depfu/update/rubocop-1.57.0 into 716268e on main.

@depfu depfu bot mentioned this pull request Oct 12, 2023
Closed
@mitlib mitlib temporarily deployed to thesis-submit-pr-1239 October 13, 2023 20:42 Inactive
@depfu
Copy link
Contributor Author

depfu bot commented Oct 14, 2023

Closed in favor of #1241.

@depfu depfu bot closed this Oct 14, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.57.0 branch October 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @mitlib