Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust language in publication results email #1247

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Nov 6, 2023

Why these changes are being introduced:

The publication results email lists theses that were "sent to preservation." This language is inaccurate; the theses are queued for preservation at this point, and may not be sent to the Archivematica bucket if the preservation job fails.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-645

How this addresses that need:

This changes the language to "Total theses queued for preservation."

Side effects of this change:

This does nothing to confirm or report on which theses were actually sent to preservation. (ETD-646 will evaluate the best way to do this.)

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

The publication results email lists theses that were "sent to
preservation." This language is inaccurate; the theses are queued
for preservation at this point, and may not be sent to the
Archivematica bucket if the preservation job fails.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-645

How this addresses that need:

This changes the language to "Total theses queued for preservation."

Side effects of this change:

This does nothing to confirm or report on which theses were actually
sent to preservation. (ETD-646 will evaluate the best way to do this.)
@mitlib mitlib temporarily deployed to thesis-submit-pr-1247 November 6, 2023 16:41 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.311%. remained the same
when pulling abf8228 on etd-645-publication-results-email
into af23f2e on main.

@JPrevost JPrevost self-assigned this Nov 6, 2023
@jazairi jazairi merged commit 337eb35 into main Nov 6, 2023
3 checks passed
@jazairi jazairi deleted the etd-645-publication-results-email branch November 6, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants