Add report emails to preservation workflow #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
force-pushed
the
etd-646-preservation-reporting-eval
branch
from
3c99cf7 to
02d1fc1
Compare
Why these changes are being introduced: We found a bug in the preservation workflow last month that we might have identified sooner if the preservation submission job triggered a report email. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/ETD-651 How this addresses that need: * Removes the Preservation Submission Prep Job * Updates the Preservation Submission Job to accept an array of theses * Adds a preservation results email to the Report Mailer that is enqueued on completion of the Preservation Submission Job * Updates the preservation rake task to convert the input thesis into an array, so it will continue to work Side effects of this change: We not sure why we implemented the 'prep' job pattern: passing in an array of theses so the actual job takes a single thesis as a parameter. There is some risk in removing this job, since we don't remember why it exists in the first place.
jazairi
force-pushed
the
etd-646-preservation-reporting-eval
branch
from
02d1fc1 to
94b3eab
Compare
JPrevost
reviewed
Nov 9, 2023
| @@ -19,4 +19,14 @@ def publication_results_email(results) | |||
| cc: ENV['MAINTAINER_EMAIL'], | |||
| subject: 'DSpace publication results summary') | |||
| end | |||
|
|
|||
| def preservation_results_email(results) | |||
| return unless ENV.fetch('DISABLE_ALL_EMAIL', 'true') == 'false' # allows PR builds to disable emails | |||
There was a problem hiding this comment.
This still breaks my brain every time I see it. I still can't parse what it does, but only know it works because it works.
JPrevost
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We found a bug in the preservation workflow last month that we might have identified sooner if the preservation submission job triggered a report email.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ETD-651
How this addresses that need:
Side effects of this change:
We not sure why we implemented the 'prep' job pattern: passing in an array of theses so the actual job takes a single thesis as a parameter. There is some risk in removing this job, since we don't remember why it exists in the first place.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO