Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.56.3 → 1.58.0 (minor) #1254

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 2, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.56.3 → 1.58.0) · Repo · Changelog

Release Notes

1.58.0

New features

Bug fixes

  • #12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. (@koic)
  • #12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. (@koic)
  • #12146: Fix a false positive for Lint/FloatComparison when comparing against zero. (@earlopain)
  • #12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. (@koic)
  • #12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. (@koic)
  • #12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. (@koic)
  • #12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. (@koic)
  • #12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. (@koic)
  • #12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. (@koic)
  • #12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. (@eugeneius)
  • #12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. (@earlopain)
  • #12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. (@koic)
  • #12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. (@koic)
  • #12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. (@koic)
  • #12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. (@koic)
  • #12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. (@koic)
  • #12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. (@koic)
  • #12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. (@koic)
  • #12424: Make Style/HashEachMethods aware of safe navigation operator. (@koic)
  • #12413: Make Style/InverseMethods aware of safe navigation operator. (@koic)
  • #12408: Make Style/MapToHash aware of safe navigation operator. (@koic)

Changes

  • #12328: Make Style/AutoResourceCleanup aware of Tempfile.open. (@koic)
  • #12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. (@fatkodima)
  • #12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. (@fatkodima)
  • #12370: Make Style/HashEachMethods aware of unused block value. (@koic)
  • #12380: Make Style/RedundantParentheses aware of lambda or proc. (@koic)
  • #12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. (@koic)
  • #12305: Require rubocop-ast version 1.30 or greater. (@sambostock)
  • #12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. (@koic)
  • #12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. (@koic)

1.57.2

Bug fixes

  • #12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. (@koic)
  • #12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. (@koic)
  • #12293: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge and method chain. (@koic)
  • #12298: Fix a false positive for Style/RedundantParentheses when using a parenthesized hash literal as the first argument in a method call without parentheses. (@koic)
  • #12283: Fix an error for Style/SingleLineDoEndBlock when using single line do...end with no body. (@koic)
  • #12312: Fix an incorrect autocorrect for Style/HashSyntax when braced hash key and value are the same and it is used in if...else. (@koic)
  • #12307: Fix an infinite loop error for Layout/EndAlignment when EnforcedStyleAlignWith: variable and using a conditional statement in a method argument on the same line and end with method call is not aligned. (@koic)
  • #11652: Make --auto-gen-config generate inherit_from correctly inside ERB if. (@jonas054)
  • #12310: Drop base64 gem from runtime dependency. (@koic)
  • #12300: Fix an error for Style/IdenticalConditionalBranches when if...else with identical leading lines and using index assign. (@koic)
  • #12286: Fix false positives for Style/RedundantDoubleSplatHashBraces when using double splat with a hash literal enclosed in parenthesized ternary operator. (@koic)
  • #12279: Fix false positives for Lint/EmptyConditionalBody when missing 2nd if body with a comment. (@koic)
  • #12275: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat within block argument containing a hash literal in an array literal. (@koic)
  • #12284: Fix false positives for Style/SingleArgumentDig when using some anonymous argument syntax. (@koic)
  • #12301: Make Style/RedundantFilterChain aware of safe navigation operator. (@koic)

1.57.1

Bug fixes

  • #12271: Fix a false positive for Lint/RedundantSafeNavigation when using snake case constant receiver. (@koic)
  • #12265: Fix an error for Layout/MultilineMethodCallIndentation when usingarithmetic operation with block inside a grouped expression. (@koic)
  • #12177: Fix an incorrect autocorrect for Style/RedundantException. (@ydah)
  • #12261: Fix an infinite loop for Layout/MultilineMethodCallIndentation when multiline method chain with a block argument and method chain. (@ydah)
  • #12263: Fix false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver. (@koic)
  • #12262: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge method call twice. (@koic)

1.57.0

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. (@koic)
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@koic)
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@koic)

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@koic)
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@koic)
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@koic)
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@knu)
  • #12198: Fix an error for flip-flop with beginless or endless ranges. (@koic)
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@koic)
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@koic)
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@koic)
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@koic)
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@koic)
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@K-S-A)

Changes

  • #12235: Enable auto parallel inspection when config file is specified. (@aboutNisblee)
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@koic)
  • #12128: Make Style/GuardClause aware of define_method. (@koic)
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@koic)
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@koic)
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@koic)
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@koic)

1.56.4

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@koic)
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@koic)
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@koic)
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@koic)
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@koic)
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@koic)
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@ydah)
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@koic)

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ json (2.6.3 → 2.7.0) · Repo · Changelog

Release Notes

2.7.0

What's Changed

Improved

  • Perf. improvements to Hash#to_json in pure implementation generator. by @vipulnsward in #203
  • Remove unnecessary initialization of create_id in JSON.parse() by @Watson1978 in #454

Added

Fixed

Compatibility changes

  • JRuby requires a minimum of Java 8 by @headius in #516
  • Rename JSON::ParseError to JSON:ParserError by @dalizard in #530
  • Removed code for Ruby 1.8 by @hsbt in #540
  • alias_method is private on Ruby 2.3 and 2.4 by @hsbt in #541
  • remove_method of Module is private at Ruby 2.3 and 2.4 by @hsbt in #544
  • [jruby] avoid using deprecated BigDecimal.new by @kares in #546
  • Always indent even if empty by @headius in #517

Misc

  • Update CI matrix by @hsbt in #521
  • Add missing changelog entries for 1.8.5 and 1.8.6 by @r7kamura in #520
  • Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows by @MSP-Greg in #491
  • Skip unsupported test on JRuby by @nobu in #532
  • Skip BigDecimal tests when it's missing to load by @hsbt in #533
  • Simplify by @nobu in #531
  • Load extension ('json/ext') consistently in test_ext by @aeroastro in #536
  • Use test-unit-ruby-core gem by @hsbt in #539
  • [CI] Add Windows mswin job by @MSP-Greg in #545
  • Exclude truffleruby-head from Actions by @hsbt in #551
  • tests/ractor_test.rb: make assert_separately available by @lucaskanashiro in #506
  • Added changes for 2.7.0 and restore entries to 2.6.3 and 2.6.2 by @hsbt in #552

New Contributors

Full Changelog: v2.6.3...v2.7.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.2.2.3 → 3.2.2.4) · Repo · Changelog

Release Notes

3.2.2.4 (from changelog)

API modifications:

  • bump Racc to 1.7.1 (#930) (Koichi ITO)

Bugs fixed:

  • Fix an error for flip-flop with beginless or endless ranges (#946) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

↗️ racc (indirect, 1.7.1 → 1.7.3) · Repo · Changelog

Release Notes

1.7.3

What's Changed

Full Changelog: v1.7.2...v1.7.3

1.7.2

What's Changed

New Contributors

Full Changelog: v1.7.1...v1.7.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 67 commits:

↗️ regexp_parser (indirect, 2.8.1 → 2.8.2) · Repo · Changelog

Release Notes

2.8.2 (from changelog)

Fixed

  • handle a corner case where parsing redundant number escapes raised an error
    • e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99
    • thanks to Markus Schirp for the report

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:

↗️ rubocop-ast (indirect, 1.29.0 → 1.30.0) · Repo · Changelog

Release Notes

1.30.0 (from changelog)

New features

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 12 commits:

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

Release Notes

2.5.0 (from changelog)

  • Unicode 15.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

🗑️ base64 (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 2, 2023
@mitlib mitlib temporarily deployed to thesis-submit-pr-1254 December 2, 2023 14:17 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.313%. remained the same
when pulling 194af11 on depfu/update/rubocop-1.58.0
into ffec3ab on main.

Copy link
Contributor Author

depfu bot commented Dec 12, 2023

Closed in favor of #1256.

@depfu depfu bot closed this Dec 12, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.58.0 branch December 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants