Update theme gem and document PLATFORM_NAME variable #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
force-pushed
the
add-app-name-to-header
branch
from
638b632 to
17d0b04
Compare
JPrevost
approved these changes
Feb 9, 2024
Why these changes are being introduced: The GDT project added a feature to the theme gem to conditionally include the platform name in the header if the `PLATFORM_NAME` environment variable is supplied. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/GDT-124 How this addresses that need: This updates the theme gem to the v1.2 tag, which includes the new feature, and documents the PLATFORM_NAME variable. It also hides the title in the navbar if PLATFORM_NAME is present. Side effects of this change: None. The app will continue to use the standard header if PLATFORM_NAME is not supplied.
jazairi
force-pushed
the
add-app-name-to-header
branch
from
3525155 to
d6a12b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The GDT project added a feature to the theme gem to conditionally include the platform name in the header if the
PLATFORM_NAMEenvironment variable is supplied.Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/GDT-124
How this addresses that need:
This updates the theme gem to the v1.2 tag, which includes the new feature, and documents the PLATFORM_NAME variable.
Side effects of this change:
None. The app will continue to use the standard header if PLATFORM_NAME is not supplied.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
YES