Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually republishing thesis in Pending publication status #1309

Merged
merged 1 commit into from
May 1, 2024

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented May 1, 2024

We had a small batch of theses not end up in the SQS queue as expected.

This small change should allow us to republish each one (one at a time) to see if we can better track down what happened (i.e. if one errors, we can assume something about it is causing this problem. If they all succeed, it was something external to an individual thesis).

This does not solve the root problem, it just allows us to more efficiently retry publication on individual theses when this app thinks they are in a publishing queue but they are not.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@JPrevost JPrevost requested review from matt-bernhardt and jazairi May 1, 2024 13:32
@mitlib mitlib temporarily deployed to thesis-submit-pr-1309 May 1, 2024 13:32 Inactive
@coveralls
Copy link

coveralls commented May 1, 2024

Coverage Status

coverage: 98.313%. remained the same
when pulling de700ad on bump-publish
into ca4f371 on main.

@jazairi jazairi self-assigned this May 1, 2024
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't confirmed the changes, but I have a high level of confidence that this will work. Before you merge this, can you update the docs for this task to mention the Pending publication status?

We had a small batch of theses not end up in the SQS queue as expected.

This small change should allow us to republish each one (one at a time) to see if we
can better track down what happened (i.e. if one errors, we can assume something about it is causing this problem. If they all succeed, it was something external to an individual thesis).

This does not solve the root problem, it just allows us to more efficiently retry publication on individual theses when this app thinks they are in a publishing queue but they are not.
@JPrevost JPrevost requested a review from jazairi May 1, 2024 13:53
@JPrevost JPrevost temporarily deployed to thesis-submit-pr-1309 May 1, 2024 13:53 Inactive
@JPrevost
Copy link
Member Author

JPrevost commented May 1, 2024

@jazairi I'm merging without review as the only change beyond your initial review was documentation in order to move this into production asap. Please do review/comment if the docs are not what you feel would be useful and we can update them in a separate PR.

@JPrevost JPrevost merged commit 5aa22e3 into main May 1, 2024
3 checks passed
@jazairi
Copy link
Contributor

jazairi commented May 1, 2024

Looks good to me! Thanks for noting the reason for including Pending publication.

Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting post-merge approval. :shipit:

@jazairi jazairi deleted the bump-publish branch May 1, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants